From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NwK0P-0004oq-3h for qemu-devel@nongnu.org; Mon, 29 Mar 2010 14:48:09 -0400 Received: from [140.186.70.92] (port=54990 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NwK0O-0004oT-3d for qemu-devel@nongnu.org; Mon, 29 Mar 2010 14:48:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NwK0L-0004dU-UF for qemu-devel@nongnu.org; Mon, 29 Mar 2010 14:48:07 -0400 Received: from mail-pw0-f45.google.com ([209.85.160.45]:61782) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NwK0L-0004dC-Mg for qemu-devel@nongnu.org; Mon, 29 Mar 2010 14:48:05 -0400 Received: by pwi9 with SMTP id 9so7773918pwi.4 for ; Mon, 29 Mar 2010 11:48:04 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4BB2465B.9040209@redhat.com> References: <4BAD1763.4040602@redhat.com> <4BB2465B.9040209@redhat.com> Date: Mon, 29 Mar 2010 21:48:03 +0300 Message-ID: Subject: Re: [Qemu-devel] [PATCH] Fix busted driftfix option From: Blue Swirl Content-Type: text/plain; charset=UTF-8 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zachary Amsden Cc: QEMU Developers On 3/30/10, Zachary Amsden wrote: > On 03/26/10 23:14, Blue Swirl wrote: > > On 3/26/10, Zachary Amsden wrote: > > > >> For some reason, this uses CONFIG_TARGET_I386 instead of TARGET_I386, so > >> the code is dead. > >> > > The code is also broken: it references undefined variable 'buf' > > instead of 'value'. > > > > > Sorry, that wasn't the case on the branch I ported from. Can you apply > a trivial fix or should I send along a patch? I've already committed the fix.