From: Eric Blake <eblake@redhat.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Igor Mitsyanko <i.mitsyanko@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] hw/arm/exynos: Convert fprintf to error_report()
Date: Mon, 6 Mar 2017 10:55:12 -0600 [thread overview]
Message-ID: <f441f1d9-b312-5f96-0fbf-53a46a8b16a8@redhat.com> (raw)
In-Reply-To: <20170305214857.9510-1-krzk@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]
On 03/05/2017 03:48 PM, Krzysztof Kozlowski wrote:
> error_report() is preferred over fprintf() for logging errors. Also
> remove square brackets [] and additional new line characters in printed
> messages.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
I don't see a 0/3 cover letter. When sending multiple patches, it's
always best to package them in-reply-to the cover letter ('git config
format.coverLetter auto' makes it easy to remember).
> @@ -101,9 +102,8 @@ static Exynos4210State *exynos4_boards_init_common(MachineState *machine,
> MachineClass *mc = MACHINE_GET_CLASS(machine);
>
> if (smp_cpus != EXYNOS4210_NCPUS && !qtest_enabled()) {
> - fprintf(stderr, "%s board supports only %d CPU cores. Ignoring smp_cpus"
> - " value.\n",
> - mc->name, EXYNOS4210_NCPUS);
> + error_report("%s board supports only %d CPU cores. Ignoring smp_cpus value.",
Most uses of error_report() avoid trailing dot.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-03-06 16:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-05 21:48 [Qemu-devel] [PATCH 1/3] hw/arm/exynos: Convert fprintf to error_report() Krzysztof Kozlowski
2017-03-05 21:48 ` [Qemu-devel] [PATCH 2/3] hw/arm/exynos4210: Constify data pointed by few arguments and variables Krzysztof Kozlowski
2017-03-06 3:58 ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2017-03-06 9:44 ` [Qemu-devel] " Peter Maydell
2017-03-06 17:14 ` Krzysztof Kozlowski
2017-03-05 21:48 ` [Qemu-devel] [PATCH 3/3] hw/misc/exynos4210_pmu: Reorder local variables for readability Krzysztof Kozlowski
2017-03-06 4:06 ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2017-03-06 9:46 ` Peter Maydell
2017-03-06 13:03 ` Paolo Bonzini
2017-03-06 13:16 ` Peter Maydell
2017-03-06 13:34 ` Philippe Mathieu-Daudé
2017-03-06 17:23 ` Krzysztof Kozlowski
2017-03-05 21:56 ` [Qemu-devel] [Qemu-arm] [PATCH 1/3] hw/arm/exynos: Convert fprintf to error_report() Philippe Mathieu-Daudé
2017-03-06 17:09 ` Krzysztof Kozlowski
2017-03-06 16:55 ` Eric Blake [this message]
2017-03-06 17:07 ` [Qemu-devel] " Krzysztof Kozlowski
2017-03-06 21:41 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f441f1d9-b312-5f96-0fbf-53a46a8b16a8@redhat.com \
--to=eblake@redhat.com \
--cc=i.mitsyanko@gmail.com \
--cc=krzk@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).