From: "Gonglei (Arei)" via <qemu-devel@nongnu.org>
To: Mauro Matteo Cascella <mcascell@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "mst@redhat.com" <mst@redhat.com>,
"pizhenwei@bytedance.com" <pizhenwei@bytedance.com>,
"taoym@zju.edu.cn" <taoym@zju.edu.cn>
Subject: RE: [PATCH] virtio-crypto: fix NULL pointer dereference in virtio_crypto_free_request
Date: Tue, 9 May 2023 01:02:22 +0000 [thread overview]
Message-ID: <f443c6c7ec2d4d2e88afeb586d5653ed@huawei.com> (raw)
In-Reply-To: <20230508150146.1092355-1-mcascell@redhat.com>
> -----Original Message-----
> From: Mauro Matteo Cascella [mailto:mcascell@redhat.com]
> Sent: Monday, May 8, 2023 11:02 PM
> To: qemu-devel@nongnu.org
> Cc: mst@redhat.com; Gonglei (Arei) <arei.gonglei@huawei.com>;
> pizhenwei@bytedance.com; taoym@zju.edu.cn; mcascell@redhat.com
> Subject: [PATCH] virtio-crypto: fix NULL pointer dereference in
> virtio_crypto_free_request
>
> Ensure op_info is not NULL in case of QCRYPTODEV_BACKEND_ALG_SYM
> algtype.
>
> Fixes: 02ed3e7c ("virtio-crypto: zeroize the key material before free")
I have to say the fixes is incorrect. The bug was introduced by commit 0e660a6f90a, which
changed the semantic meaning of request-> flag.
Regards,
-Gonglei
next prev parent reply other threads:[~2023-05-09 1:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 15:01 [PATCH] virtio-crypto: fix NULL pointer dereference in virtio_crypto_free_request Mauro Matteo Cascella
2023-05-09 1:02 ` Gonglei (Arei) via [this message]
2023-05-09 1:45 ` zhenwei pi
2023-05-09 7:54 ` Mauro Matteo Cascella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f443c6c7ec2d4d2e88afeb586d5653ed@huawei.com \
--to=qemu-devel@nongnu.org \
--cc=arei.gonglei@huawei.com \
--cc=mcascell@redhat.com \
--cc=mst@redhat.com \
--cc=pizhenwei@bytedance.com \
--cc=taoym@zju.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).