From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72D07C77B7F for ; Tue, 9 May 2023 01:03:38 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pwBkc-0005wn-41; Mon, 08 May 2023 21:02:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwBkZ-0005wD-KT for qemu-devel@nongnu.org; Mon, 08 May 2023 21:02:43 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwBkX-0003Gm-2q for qemu-devel@nongnu.org; Mon, 08 May 2023 21:02:43 -0400 Received: from kwepemi100013.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QFfs74gFNzTjxv; Tue, 9 May 2023 08:57:47 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by kwepemi100013.china.huawei.com (7.221.188.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 9 May 2023 09:02:23 +0800 Received: from dggpemm500006.china.huawei.com ([7.185.36.236]) by dggpemm500006.china.huawei.com ([7.185.36.236]) with mapi id 15.01.2507.023; Tue, 9 May 2023 09:02:23 +0800 To: Mauro Matteo Cascella , "qemu-devel@nongnu.org" CC: "mst@redhat.com" , "pizhenwei@bytedance.com" , "taoym@zju.edu.cn" Subject: RE: [PATCH] virtio-crypto: fix NULL pointer dereference in virtio_crypto_free_request Thread-Topic: [PATCH] virtio-crypto: fix NULL pointer dereference in virtio_crypto_free_request Thread-Index: AQHZgb4Xn07N6c7VrEmQg3bODoBT969RHXIQ Date: Tue, 9 May 2023 01:02:22 +0000 Message-ID: References: <20230508150146.1092355-1-mcascell@redhat.com> In-Reply-To: <20230508150146.1092355-1-mcascell@redhat.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.149.11] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected Received-SPF: pass client-ip=45.249.212.188; envelope-from=arei.gonglei@huawei.com; helo=szxga02-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: "Gonglei (Arei)" From: "Gonglei (Arei)" via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org > -----Original Message----- > From: Mauro Matteo Cascella [mailto:mcascell@redhat.com] > Sent: Monday, May 8, 2023 11:02 PM > To: qemu-devel@nongnu.org > Cc: mst@redhat.com; Gonglei (Arei) ; > pizhenwei@bytedance.com; taoym@zju.edu.cn; mcascell@redhat.com > Subject: [PATCH] virtio-crypto: fix NULL pointer dereference in > virtio_crypto_free_request >=20 > Ensure op_info is not NULL in case of QCRYPTODEV_BACKEND_ALG_SYM > algtype. >=20 > Fixes: 02ed3e7c ("virtio-crypto: zeroize the key material before free") I have to say the fixes is incorrect. The bug was introduced by commit 0e66= 0a6f90a, which changed the semantic meaning of request-> flag. Regards, -Gonglei