From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD578C433E5 for ; Fri, 24 Jul 2020 18:09:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC6EB20674 for ; Fri, 24 Jul 2020 18:09:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TDSQ0neC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC6EB20674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57938 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jz28W-00036D-SC for qemu-devel@archiver.kernel.org; Fri, 24 Jul 2020 14:09:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49678) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jz27h-0002et-U9 for qemu-devel@nongnu.org; Fri, 24 Jul 2020 14:08:46 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:28113 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jz27f-0007TS-K7 for qemu-devel@nongnu.org; Fri, 24 Jul 2020 14:08:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595614122; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6h4yitJKSiCoywdjOwFILE6NNXP7QsoBmi43ifYr2xY=; b=TDSQ0neCkYUyQe1y2jBr9oNxe1At5aOJixeu0VNKaYLShKK+QrWMMUHyR73Jsa0P55pmxk rQ2MohkbJIdYKQBc+gGiIT0W+Kxz45MUbreEDk+FJt0NS9m9sUWkeKY2lisJ6YdW30D8u4 4qNDDcAoxuuDKp36TaRQD3iZ+dluRNs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-143-DW8Rm5v6NgC-C-jGDtBp8A-1; Fri, 24 Jul 2020 14:08:38 -0400 X-MC-Unique: DW8Rm5v6NgC-C-jGDtBp8A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A61D1102C7E9; Fri, 24 Jul 2020 18:08:36 +0000 (UTC) Received: from [10.3.112.130] (ovpn-112-130.phx2.redhat.com [10.3.112.130]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9F79470596; Fri, 24 Jul 2020 18:08:32 +0000 (UTC) Subject: Re: [PATCH v3 17/21] migration/savevm: don't worry if bitmap migration postcopy failed To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org References: <20200724084327.15665-1-vsementsov@virtuozzo.com> <20200724084327.15665-18-vsementsov@virtuozzo.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: Date: Fri, 24 Jul 2020 13:08:32 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200724084327.15665-18-vsementsov@virtuozzo.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.81; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/24 14:08:42 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, fam@euphon.net, quintela@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com, stefanha@redhat.com, andrey.shinkevich@virtuozzo.com, den@openvz.org, mreitz@redhat.com, jsnow@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/24/20 3:43 AM, Vladimir Sementsov-Ogievskiy wrote: > First, if only bitmaps postcopy enabled (not ram postcopy) is enabled (and not ram postcopy), > postcopy_pause_incoming crashes on assertion assert(mis->to_src_file). on an > > And anyway, bitmaps postcopy is not prepared to be somehow recovered. > The original idea instead is that if bitmaps postcopy failed, we just > loss some bitmaps, which is not critical. So, on failure we just need lose > to remove unfinished bitmaps and guest should continue execution on > destination. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Dr. David Alan Gilbert > Reviewed-by: Andrey Shinkevich > --- > migration/savevm.c | 37 ++++++++++++++++++++++++++++++++----- > 1 file changed, 32 insertions(+), 5 deletions(-) > Definitely a bug fix, but I'd like David's opinion on whether this is still 5.1 material (because it is limited to just bitmaps migration, which is opt-in) or too risky (because we've already had several releases where it was broken, what's one more?). I'm less familiar with the code, so this is weak, but I did read through it and nothing jumped out at me, so: Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org