From: Thomas Huth <thuth@redhat.com>
To: QEMU Developers <qemu-devel@nongnu.org>,
Subbaraya Sundeep <sundeep.lkml@gmail.com>
Cc: qemu-arm <qemu-arm@nongnu.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: Test failure with Smartfusion2 emac block (msf2-emac)
Date: Tue, 7 Jul 2020 07:32:52 +0200 [thread overview]
Message-ID: <f457f5d9-2405-4456-4a26-b3a9784e2cd9@redhat.com> (raw)
In-Reply-To: <e010da48-cfbe-9616-d750-a922cb463a94@redhat.com>
On 07/07/2020 07.18, Thomas Huth wrote:
>
> Hi Subbaraya,
>
> today, I noticed that there is a test failure with msf2-emac when
> running the device-introspect-test in slow mode. Either run:
>
> make check-qtest-aarch64 SPEED=slow
>
> or as a shortcut:
>
> make tests/qtest/device-introspect-test
> QTEST_QEMU_BINARY="aarch64-softmmu/qemu-system-aarch64" \
> ./tests/qtest/device-introspect-test -m slow
>
> Then the test fails with:
>
> Unexpected error in error_set_from_qdev_prop_error() at
> hw/core/qdev-properties.c:1251:
> Property 'msf2-emac.netdev' can't take value 'hub0port0', it's in use
>
> Could you please have a look?
The problem might be related to m2sxxx_soc_initfn() in msf2-soc.c. Looks
like you are using nd_table in an instance_init function. This is almost
always wrong, and should be done by the machine code instead (e.g. in
msf2-som.c).
Thomas
PS: Maybe also have a look at this article, it might help to understand
the idea behind instance_init a little bit:
http://people.redhat.com/~thuth/blog/qemu/2018/09/10/instance-init-realize.html
next prev parent reply other threads:[~2020-07-07 5:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 5:18 Test failure with Smartfusion2 emac block (msf2-emac) Thomas Huth
2020-07-07 5:32 ` Thomas Huth [this message]
2020-07-14 14:42 ` Philippe Mathieu-Daudé
2020-07-16 2:50 ` sundeep subbaraya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f457f5d9-2405-4456-4a26-b3a9784e2cd9@redhat.com \
--to=thuth@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sundeep.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).