From: Richard Henderson <richard.henderson@linaro.org>
To: Laurent Vivier <laurent@vivier.eu>,
Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH 0/2] linux-user: Load a vdso for x86_64
Date: Thu, 28 May 2020 14:42:15 -0700 [thread overview]
Message-ID: <f46f5f0a-3a56-538a-e703-0a6afb78ae3d@linaro.org> (raw)
In-Reply-To: <e985a1cb-e4e3-6faa-f158-5e797d0b5e92@vivier.eu>
On 5/28/20 3:32 AM, Laurent Vivier wrote:
> Le 28/05/2020 à 12:08, Peter Maydell a écrit :
>> On Tue, 19 May 2020 at 20:45, Richard Henderson
>> <richard.henderson@linaro.org> wrote:
>>> Makefile | 4 +-
>>> linux-user/elfload.c | 203 +++++++++++++++++++++++++++++++++++++-
>>> pc-bios/Makefile | 5 +
>>> pc-bios/vdso-linux-x64.S | 115 +++++++++++++++++++++
>>> pc-bios/vdso-linux-x64.ld | 81 +++++++++++++++
>>> pc-bios/vdso-linux-x64.so | Bin 0 -> 7500 bytes
>>
>> I'm not really a fan of binaries in source control :-(
>
> Can't we see that as a firmware or a ROM?
> It's only 7,4 KB and needs a cross-compilation env to be rebuilt.
>
> Do you have another solution?
>
> If you don't like this I can remove the series. Let me know.
I think some more of the questions in the cover letter need answering. Does
this patch set not break your own --static chroot tests, for example?
r~
next prev parent reply other threads:[~2020-05-28 21:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 19:44 [PATCH 0/2] linux-user: Load a vdso for x86_64 Richard Henderson
2020-05-19 19:44 ` [PATCH 1/2] linux-user: Build vdso for x64 Richard Henderson
2020-05-19 19:44 ` [PATCH 2/2] linux-user: Load a VDSO for x86-64 Richard Henderson
2020-05-28 9:54 ` [PATCH 0/2] linux-user: Load a vdso for x86_64 Laurent Vivier
2020-05-28 10:08 ` Peter Maydell
2020-05-28 10:32 ` Laurent Vivier
2020-05-28 13:20 ` Philippe Mathieu-Daudé
2020-05-28 21:42 ` Richard Henderson [this message]
2020-05-29 8:50 ` Laurent Vivier
2020-05-29 8:58 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f46f5f0a-3a56-538a-e703-0a6afb78ae3d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).