From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Max Reitz <mreitz@redhat.com>, Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org
Subject: Re: [PATCH for-5.1] iotests: Select a default machine for the rx and avr targets
Date: Fri, 24 Jul 2020 11:32:32 +0200 [thread overview]
Message-ID: <f471c61f-1a87-5bf4-2e6c-e504d5493bff@redhat.com> (raw)
In-Reply-To: <4224587f-2d68-53a4-5ff4-ac3d6279a29b@redhat.com>
Hi Max/Kevin,
On 7/24/20 10:24 AM, Max Reitz wrote:
> On 22.07.20 18:19, Thomas Huth wrote:
>> If you are building only with either the new rx-softmmu or avr-softmmu
>> target, "make check-block" fails a couple of tests since there is no
>> default machine defined in these new targets. We have to select a machine
>> in the "check" script for these, just like we already do for the arm- and
>> tricore-softmmu targets.
I guess remember I already asked on IRC but can't find the log,
so better ask again on the list.
Why can't we use the 'none' machine for the block tests? What
part of the machines is required? I was thinking maybe busses,
but apparently not (example with these 2 machines).
Thanks,
Phil.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> tests/qemu-iotests/check | 14 +++++++++-----
>> 1 file changed, 9 insertions(+), 5 deletions(-)
>
> Thanks, applied to my block branch:
>
> https://git.xanclic.moe/XanClic/qemu/commits/branch/block
>
prev parent reply other threads:[~2020-07-24 9:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 16:19 [PATCH for-5.1] iotests: Select a default machine for the rx and avr targets Thomas Huth
2020-07-24 8:24 ` Max Reitz
2020-07-24 9:32 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f471c61f-1a87-5bf4-2e6c-e504d5493bff@redhat.com \
--to=philmd@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).