From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gG3Y3-0004K1-0c for qemu-devel@nongnu.org; Fri, 26 Oct 2018 10:57:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gG3Xz-0004u8-Qw for qemu-devel@nongnu.org; Fri, 26 Oct 2018 10:57:14 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]:50358) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gG3Xz-0004tn-Dd for qemu-devel@nongnu.org; Fri, 26 Oct 2018 10:57:11 -0400 Received: by mail-wm1-x32d.google.com with SMTP id i8-v6so1802442wmg.0 for ; Fri, 26 Oct 2018 07:57:11 -0700 (PDT) References: <20181025144644.15464-1-cota@braap.org> <20181025144644.15464-7-cota@braap.org> From: Richard Henderson Message-ID: Date: Fri, 26 Oct 2018 15:57:07 +0100 MIME-Version: 1.0 In-Reply-To: <20181025144644.15464-7-cota@braap.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v4 07/71] tcg-runtime: define helper_cpu_halted_set List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Emilio G. Cota" , qemu-devel@nongnu.org Cc: Paolo Bonzini On 10/25/18 3:45 PM, Emilio G. Cota wrote: > +void HELPER(cpu_halted_set)(CPUArchState *env, uint32_t val) > +{ > + CPUState *cpu = ENV_GET_CPU(env); > + > + cpu->halted = val; > +} I suppose this is fine as a first step. I'd like to clean up all of the targets to also use a helper like this to also raise EXCP_HALTED. They all perform the same actions, even though this isn't obvious (many of them reuse helpers that also raise target-specific exceptions). That said, Reviewed-by: Richard Henderson r~