qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: Greg Kurz <groug@kaod.org>, David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-4.1 1/2] spapr/irq: Inform the user when falling back to emulated IC
Date: Wed, 24 Jul 2019 19:07:57 +0200	[thread overview]
Message-ID: <f475ac78-d96b-586f-f3b8-5db7183eb41f@kaod.org> (raw)
In-Reply-To: <156398743479.546975.14566809803480887488.stgit@bahia.lan>

On 24/07/2019 18:57, Greg Kurz wrote:
> Just to give an indication to the user that the error condition is
> handled and how.
> 
> Reported-by: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
> Signed-off-by: Greg Kurz <groug@kaod.org>



Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.

> ---
>  hw/ppc/spapr_irq.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/ppc/spapr_irq.c b/hw/ppc/spapr_irq.c
> index ff3df0bbd8cf..d07aed8ca9f9 100644
> --- a/hw/ppc/spapr_irq.c
> +++ b/hw/ppc/spapr_irq.c
> @@ -86,6 +86,7 @@ static void spapr_irq_init_kvm(SpaprMachineState *spapr,
>           * emulated mode
>           */
>          error_prepend(&local_err, "kernel_irqchip allowed but unavailable: ");
> +        error_append_hint(&local_err, "Falling back to kernel-irqchip=off\n");
>          warn_report_err(local_err);
>      }
>  }
> 



  reply	other threads:[~2019-07-24 17:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-24 16:57 [Qemu-devel] [PATCH for-4.1 0/2] spapr/xics: Last minute fixes Greg Kurz
2019-07-24 16:57 ` [Qemu-devel] [PATCH for-4.1 1/2] spapr/irq: Inform the user when falling back to emulated IC Greg Kurz
2019-07-24 17:07   ` Cédric Le Goater [this message]
2019-07-24 16:57 ` [Qemu-devel] [PATCH for-4.1 2/2] xics/kvm: Fix fallback to emulated XICS Greg Kurz
2019-07-24 17:17   ` Cédric Le Goater
2019-07-25  3:38 ` [Qemu-devel] [PATCH for-4.1 0/2] spapr/xics: Last minute fixes David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f475ac78-d96b-586f-f3b8-5db7183eb41f@kaod.org \
    --to=clg@kaod.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=groug@kaod.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).