From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C4D3C43334 for ; Mon, 27 Jun 2022 16:59:13 +0000 (UTC) Received: from localhost ([::1]:50240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o5s4u-0005BL-MK for qemu-devel@archiver.kernel.org; Mon, 27 Jun 2022 12:59:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55242) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5rfo-0001Qn-TD for qemu-devel@nongnu.org; Mon, 27 Jun 2022 12:33:17 -0400 Received: from smtpout4.mo529.mail-out.ovh.net ([217.182.185.173]:55479) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5rfj-0004j3-4k for qemu-devel@nongnu.org; Mon, 27 Jun 2022 12:33:16 -0400 Received: from mxplan5.mail.ovh.net (unknown [10.109.143.167]) by mo529.mail-out.ovh.net (Postfix) with ESMTPS id B472E111DC919; Mon, 27 Jun 2022 18:33:08 +0200 (CEST) Received: from kaod.org (37.59.142.102) by DAG4EX1.mxp5.local (172.16.2.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Mon, 27 Jun 2022 18:33:07 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-102R00438de6169-8622-491a-8a5c-195e37d4bd23, 659C98CE65B422D4D127A36693B7EAD6442F0B22) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.64.250.170 Message-ID: Date: Mon, 27 Jun 2022 18:33:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2 0/7] Add Qualcomm BMC machines Content-Language: en-US To: Jae Hyun Yoo , Peter Maydell , Titus Rwantare , Andrew Jeffery , Joel Stanley , Patrick Venture , Hao Wu CC: Graeme Gregory , Maheswara Kurapati , , References: <20220627154703.148943-1-quic_jaehyoo@quicinc.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <20220627154703.148943-1-quic_jaehyoo@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [37.59.142.102] X-ClientProxiedBy: DAG4EX1.mxp5.local (172.16.2.31) To DAG4EX1.mxp5.local (172.16.2.31) X-Ovh-Tracer-GUID: 3b7343b0-0e1b-42aa-b585-bd22f36849f3 X-Ovh-Tracer-Id: 15835782191662140405 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrudeghedguddtgecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfevfhfhjggtgfhisehtjeertddtfeejnecuhfhrohhmpeevrogurhhitggpnfgvpgfiohgrthgvrhcuoegtlhhgsehkrghougdrohhrgheqnecuggftrfgrthhtvghrnhepleelieeigfekfeeitddvieegteeuteekffekleehuefgteetgedvkefghefggfeknecukfhppedtrddtrddtrddtpdefjedrheelrddugedvrddutddvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehmgihplhgrnhehrdhmrghilhdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheptghlgheskhgrohgurdhorhhgpdhnsggprhgtphhtthhopedupdhrtghpthhtohepqhgvmhhuqdguvghvvghlsehnohhnghhnuhdrohhrghdpoffvtefjohhsthepmhhohedvle Received-SPF: pass client-ip=217.182.185.173; envelope-from=clg@kaod.org; helo=smtpout4.mo529.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hello Titus, On 6/27/22 17:46, Jae Hyun Yoo wrote: > Hello, > > I'm sending a series to add Qualcomm BMC machines that are equipped with > Aspeed AST2600 SoC. Also, this series adds MAX31785 fan controller device > emulation. Please help to review. > > Thanks, > > Jae > > Changes in v2: > * Fixed a typo in QCOM DC-SCM V1 HW strap value comment. (Rebecca) > * Removed a useless change which is reverted by the next patch. (Joel) > * Changed machine name to 'qcom-firework-bmc'. (Cedric) > * Dropped FRU eeprom initialization part. (Patrick) > * Fixed comment for a case of PB_ALL_PAGES. (Titus) > * Removed an error log printing when it handles PB_ALL_PAGES. (Jae) > * Fixed a typo in copyright in max31785.c. (Rebecca) > * Fixed indentation issues in max31785.c. (Titus) > * Fixed license identifier style and refined indentation of defines. (Jae) > * Added PMBUS and MAX31785 config selection under ASPEED_SOC. (Titus) > * Moved machine updating part from the previous patch. (Cedric) > * Refined code to avoid retouching by the next patch. (Joel) > > Graeme Gregory (1): > hw/arm/aspeed: add Qualcomm Firework BMC machine > > Jae Hyun Yoo (2): > hw/arm/aspeed: add support for the Qualcomm DC-SCM v1 board > hw/arm/aspeed: firework: add I2C MUXes for VR channels > > Maheswara Kurapati (4): > hw/i2c: pmbus: Page #255 is valid page for read requests. > hw/sensor: add Maxim MAX31785 device > hw/arm/aspeed: Add MAX31785 Fan controllers > hw/arm/aspeed: firework: Add Thermal Diodes > > hw/arm/Kconfig | 2 + > hw/arm/aspeed.c | 95 ++++++- > hw/i2c/pmbus_device.c | 6 +- > hw/sensor/Kconfig | 4 + > hw/sensor/max31785.c | 573 ++++++++++++++++++++++++++++++++++++++++++ > hw/sensor/meson.build | 1 + > 6 files changed, 674 insertions(+), 7 deletions(-) > create mode 100644 hw/sensor/max31785.c Will you handle the pmbus/sensor patches or would you mind if I took them through the aspeed branch ? Thanks, C.