From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lwhp7-0004NL-Lr for qemu-devel@nongnu.org; Wed, 22 Apr 2009 15:09:33 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lwhp7-0004Mu-36 for qemu-devel@nongnu.org; Wed, 22 Apr 2009 15:09:33 -0400 Received: from [199.232.76.173] (port=60061 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lwhp6-0004Mm-U1 for qemu-devel@nongnu.org; Wed, 22 Apr 2009 15:09:32 -0400 Received: from yw-out-1718.google.com ([74.125.46.157]:43856) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lwhp6-0004B9-F3 for qemu-devel@nongnu.org; Wed, 22 Apr 2009 15:09:32 -0400 Received: by yw-out-1718.google.com with SMTP id 5so7688ywr.82 for ; Wed, 22 Apr 2009 12:09:31 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1240427257-82919-1-git-send-email-steven@uplinklabs.net> References: <1240427257-82919-1-git-send-email-steven@uplinklabs.net> Date: Wed, 22 Apr 2009 12:09:31 -0700 Message-ID: From: Steven Noonan Content-Type: multipart/alternative; boundary=00163630f0efd687b00468298078 Subject: [Qemu-devel] Re: [PATCH] sasl, tls: fix compilation on systems with nonstandard install points List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Steven Noonan --00163630f0efd687b00468298078 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sorry, did not intend to send this twice. Took a bit to get postfix working and then it sent a ton of queued messages. On Wed, Apr 22, 2009 at 12:07 PM, Steven Noonan wrote: > Users of MacPorts will experience this problem if they install > gnutls through 'port install'. The object files vnc-tls.o and > vnc-auth-vencrypt.o aren't compiled with the right flags and > end up causing compiler errors about missing headers, etc. This > patch corrects this by adding the flags to the objects which > complain without them. > > Signed-off-by: Steven Noonan > --- > Makefile | 8 +++++++- > 1 files changed, 7 insertions(+), 1 deletions(-) > > diff --git a/Makefile b/Makefile > index ed887de..fb4cb4f 100644 > --- a/Makefile > +++ b/Makefile > @@ -194,14 +194,20 @@ vnc.h: vnc-tls.h vnc-auth-vencrypt.h vnc-auth-sasl.h > keymaps.h > > vnc.o: vnc.c vnc.h vnc_keysym.h vnchextile.h d3des.c d3des.h acl.h > > -vnc.o: CFLAGS += $(CONFIG_VNC_TLS_CFLAGS) > +vnc.o: CFLAGS += $(CONFIG_VNC_TLS_CFLAGS) $(CONFIG_VNC_SASL_CFLAGS) > > vnc-tls.o: vnc-tls.c vnc.h > > +vnc-tls.o: CFLAGS += $(CONFIG_VNC_TLS_CFLAGS) $(CONFIG_VNC_SASL_CFLAGS) > + > vnc-auth-vencrypt.o: vnc-auth-vencrypt.c vnc.h > > +vnc-auth-vencrypt.o: CFLAGS += $(CONFIG_VNC_TLS_CFLAGS) > $(CONFIG_VNC_SASL_CFLAGS) > + > vnc-auth-sasl.o: vnc-auth-sasl.c vnc.h > > +vnc-auth-sasl.o: CFLAGS += $(CONFIG_VNC_TLS_CFLAGS) > $(CONFIG_VNC_SASL_CFLAGS) > + > curses.o: curses.c keymaps.h curses_keys.h > > bt-host.o: CFLAGS += $(CONFIG_BLUEZ_CFLAGS) > -- > 1.6.2.1 > > --00163630f0efd687b00468298078 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Sorry, did not intend to send this twice. Took a bit to get postfix working= and then it sent a ton of queued messages.

On Wed, Apr 22, 2009 at 12:07 PM, Steven Noonan <steven@uplinklabs.net>= wrote:
Users of = MacPorts will experience this problem if they install
gnutls through 'port install'. The object files vnc-tls.o and
vnc-auth-vencrypt.o aren't compiled with the right flags and
end up causing compiler errors about missing headers, etc. This
patch corrects this by adding the flags to the objects which
complain without them.

Signed-off-by: Steven Noonan <s= teven@uplinklabs.net>
---
=A0Makefile | =A0 =A08 +++++++-
=A01 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index ed887de..fb4cb4f 100644
--- a/Makefile
+++ b/Makefile
@@ -194,14 +194,20 @@ vnc.h: vnc-tls.h vnc-auth-vencrypt.h vnc-auth-sasl.h = keymaps.h

=A0vnc.o: vnc.c vnc.h vnc_keysym.h vnchextile.h d3des.c d3des.h acl.h

-vnc.o: CFLAGS +=3D $(CONFIG_VNC_TLS_CFLAGS)
+vnc.o: CFLAGS +=3D $(CONFIG_VNC_TLS_CFLAGS) $(CONFIG_VNC_SASL_CFLAGS)

=A0vnc-tls.o: vnc-tls.c vnc.h

+vnc-tls.o: CFLAGS +=3D $(CONFIG_VNC_TLS_CFLAGS) $(CONFIG_VNC_SASL_CFLAGS)<= br> +
=A0vnc-auth-vencrypt.o: vnc-auth-vencrypt.c vnc.h

+vnc-auth-vencrypt.o: CFLAGS +=3D $(CONFIG_VNC_TLS_CFLAGS) $(CONFIG_VNC_SAS= L_CFLAGS)
+
=A0vnc-auth-sasl.o: vnc-auth-sasl.c vnc.h

+vnc-auth-sasl.o: CFLAGS +=3D $(CONFIG_VNC_TLS_CFLAGS) $(CONFIG_VNC_SASL_CF= LAGS)
+
=A0curses.o: curses.c keymaps.h curses_keys.h

=A0bt-host.o: CFLAGS +=3D $(CONFIG_BLUEZ_CFLAGS)
--
1.6.2.1


--00163630f0efd687b00468298078--