qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: mst@redhat.com, anisinha@redhat.com
Subject: Re: [PATCH 2/3] pci: acpi: Windows 'PCI Label Id' bug workaround
Date: Thu, 16 Jan 2025 17:27:57 +0100	[thread overview]
Message-ID: <f49b2c63-33aa-446a-bf47-a59faf49dc2a@proxmox.com> (raw)
In-Reply-To: <20250115125342.3883374-3-imammedo@redhat.com>

Am 15.01.25 um 13:53 schrieb Igor Mammedov:
> Current versions of Windows call _DSM(func=7) regardless
> of whether it is supported or not. It leads to NICs having bogus
> 'PCI Label Id = 0', where none should be set at all.
> 
> Also presence of 'PCI Label Id' triggers another Windows bug
> on localized versions that leads to hangs. The later bug is fixed
> in latest updates for 'Windows Server' but not in consumer
> versions of Windows (and there is no plans to fix it
> as far as I'm aware).
> 
> Given it's easy, implement Microsoft suggested workaround
> (return invalid Package) so that affected Windows versions
> could boot on QEMU.
> This would effectvely remove bogus 'PCI Label Id's on NICs,
> but MS teem confirmed that flipping 'PCI Label Id' should not
> change 'Network Connection' ennumeration, so it should be safe
> for QEMU to change _DSM without any compat code.
> 
> Smoke tested with WinXP and WS2022
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/774
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>

Tested-by: Fiona Ebner <f.ebner@proxmox.com>

Fixes the VirtIO NIC issue with a German Windows 10 guest for me.



  reply	other threads:[~2025-01-16 16:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-15 12:53 [PATCH 0/3] workaround Windows always reading _DSM(func=7) Igor Mammedov
2025-01-15 12:53 ` [PATCH 1/3] tests: acpi: whitelist expected blobs Igor Mammedov
2025-01-15 14:09   ` Ani Sinha
2025-01-15 12:53 ` [PATCH 2/3] pci: acpi: Windows 'PCI Label Id' bug workaround Igor Mammedov
2025-01-16 16:27   ` Fiona Ebner [this message]
2025-01-17  6:29   ` Michael Tokarev
2025-01-17  7:05   ` Ani Sinha
2025-01-15 12:53 ` [PATCH 3/3] tests: acpi: update expected blobs Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f49b2c63-33aa-446a-bf47-a59faf49dc2a@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=anisinha@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).