From: Laurent Vivier <laurent@vivier.eu>
To: Matus Kysel <mkysel@tachyum.com>
Cc: "open list:All patches CC here" <qemu-devel@nongnu.org>
Subject: Re: [PATCH] linux-user: correct errno returned from accept4() syscall
Date: Wed, 30 Sep 2020 19:19:25 +0200 [thread overview]
Message-ID: <f49dba9c-c3b4-b39d-b160-de250bf63b7d@vivier.eu> (raw)
In-Reply-To: <20200930151616.3588165-1-mkysel@tachyum.com>
Le 30/09/2020 à 17:16, Matus Kysel a écrit :
> accept4() returned wrong errno, that did not match current linux
>
> Signed-off-by: Matus Kysel <mkysel@tachyum.com>
> ---
> linux-user/syscall.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 897d20c076..5b8c20cf21 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -3491,16 +3491,16 @@ static abi_long do_accept4(int fd, abi_ulong target_addr,
> return get_errno(safe_accept4(fd, NULL, NULL, host_flags));
> }
>
> - /* linux returns EINVAL if addrlen pointer is invalid */
> + /* linux returns EFAULT if addrlen pointer is invalid */
> if (get_user_u32(addrlen, target_addrlen_addr))
> - return -TARGET_EINVAL;
> + return -TARGET_EFAULT;
>
> if ((int)addrlen < 0) {
> return -TARGET_EINVAL;
> }
>
> if (!access_ok(VERIFY_WRITE, target_addr, addrlen))
> - return -TARGET_EINVAL;
> + return -TARGET_EFAULT;
>
> addr = alloca(addrlen);
>
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
next prev parent reply other threads:[~2020-09-30 17:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 15:16 [PATCH] linux-user: correct errno returned from accept4() syscall Matus Kysel
2020-09-30 17:19 ` Laurent Vivier [this message]
2020-10-26 11:00 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f49dba9c-c3b4-b39d-b160-de250bf63b7d@vivier.eu \
--to=laurent@vivier.eu \
--cc=mkysel@tachyum.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).