* [PATCH] linux-user: correct errno returned from accept4() syscall
@ 2020-09-30 15:16 Matus Kysel
2020-09-30 17:19 ` Laurent Vivier
2020-10-26 11:00 ` Laurent Vivier
0 siblings, 2 replies; 3+ messages in thread
From: Matus Kysel @ 2020-09-30 15:16 UTC (permalink / raw)
To: mkysel; +Cc: Laurent Vivier, open list:All patches CC here
accept4() returned wrong errno, that did not match current linux
Signed-off-by: Matus Kysel <mkysel@tachyum.com>
---
linux-user/syscall.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 897d20c076..5b8c20cf21 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -3491,16 +3491,16 @@ static abi_long do_accept4(int fd, abi_ulong target_addr,
return get_errno(safe_accept4(fd, NULL, NULL, host_flags));
}
- /* linux returns EINVAL if addrlen pointer is invalid */
+ /* linux returns EFAULT if addrlen pointer is invalid */
if (get_user_u32(addrlen, target_addrlen_addr))
- return -TARGET_EINVAL;
+ return -TARGET_EFAULT;
if ((int)addrlen < 0) {
return -TARGET_EINVAL;
}
if (!access_ok(VERIFY_WRITE, target_addr, addrlen))
- return -TARGET_EINVAL;
+ return -TARGET_EFAULT;
addr = alloca(addrlen);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] linux-user: correct errno returned from accept4() syscall
2020-09-30 15:16 [PATCH] linux-user: correct errno returned from accept4() syscall Matus Kysel
@ 2020-09-30 17:19 ` Laurent Vivier
2020-10-26 11:00 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2020-09-30 17:19 UTC (permalink / raw)
To: Matus Kysel; +Cc: open list:All patches CC here
Le 30/09/2020 à 17:16, Matus Kysel a écrit :
> accept4() returned wrong errno, that did not match current linux
>
> Signed-off-by: Matus Kysel <mkysel@tachyum.com>
> ---
> linux-user/syscall.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 897d20c076..5b8c20cf21 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -3491,16 +3491,16 @@ static abi_long do_accept4(int fd, abi_ulong target_addr,
> return get_errno(safe_accept4(fd, NULL, NULL, host_flags));
> }
>
> - /* linux returns EINVAL if addrlen pointer is invalid */
> + /* linux returns EFAULT if addrlen pointer is invalid */
> if (get_user_u32(addrlen, target_addrlen_addr))
> - return -TARGET_EINVAL;
> + return -TARGET_EFAULT;
>
> if ((int)addrlen < 0) {
> return -TARGET_EINVAL;
> }
>
> if (!access_ok(VERIFY_WRITE, target_addr, addrlen))
> - return -TARGET_EINVAL;
> + return -TARGET_EFAULT;
>
> addr = alloca(addrlen);
>
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] linux-user: correct errno returned from accept4() syscall
2020-09-30 15:16 [PATCH] linux-user: correct errno returned from accept4() syscall Matus Kysel
2020-09-30 17:19 ` Laurent Vivier
@ 2020-10-26 11:00 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2020-10-26 11:00 UTC (permalink / raw)
To: Matus Kysel; +Cc: open list:All patches CC here
Le 30/09/2020 à 17:16, Matus Kysel a écrit :
> accept4() returned wrong errno, that did not match current linux
>
> Signed-off-by: Matus Kysel <mkysel@tachyum.com>
> ---
> linux-user/syscall.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 897d20c076..5b8c20cf21 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -3491,16 +3491,16 @@ static abi_long do_accept4(int fd, abi_ulong target_addr,
> return get_errno(safe_accept4(fd, NULL, NULL, host_flags));
> }
>
> - /* linux returns EINVAL if addrlen pointer is invalid */
> + /* linux returns EFAULT if addrlen pointer is invalid */
> if (get_user_u32(addrlen, target_addrlen_addr))
> - return -TARGET_EINVAL;
> + return -TARGET_EFAULT;
>
> if ((int)addrlen < 0) {
> return -TARGET_EINVAL;
> }
>
> if (!access_ok(VERIFY_WRITE, target_addr, addrlen))
> - return -TARGET_EINVAL;
> + return -TARGET_EFAULT;
>
> addr = alloca(addrlen);
>
>
Applied to my linux-user-for-5.2 branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-26 11:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-30 15:16 [PATCH] linux-user: correct errno returned from accept4() syscall Matus Kysel
2020-09-30 17:19 ` Laurent Vivier
2020-10-26 11:00 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).