qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
	qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Cc: Jiri Denemark <jdenemar@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4] qapi: Add device ID and head parameters to screendump
Date: Mon, 12 Mar 2018 10:00:23 -0500	[thread overview]
Message-ID: <f4c8a7a8-9b2b-1dbc-0cd4-005c8784df0f@redhat.com> (raw)
In-Reply-To: <2eb04741-4dcd-1f57-4786-ca8328502b79@redhat.com>

On 03/10/2018 09:05 PM, Eric Blake wrote:
> On 03/05/2018 10:37 AM, Thomas Huth wrote:
>> QEMU's screendump command can only take dumps from the primary display.
>> When using multiple VGA cards, there is no way to get a dump from a
>> secondary card or other display heads yet. So let's add an 'device' and
>> a 'head' parameter to the HMP and QMP commands to be able to specify
>> alternative devices and heads with the screendump command, too.
>>
>> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>> Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>   v4:
>>   - Improved the documentation of the parameters in ui.json a little bit
>>     (according to the suggestions from Eric)
> 
> We're getting close to soft freeze; I'll include this in my QAPI tree, 
> since I have an upcoming pull request, rather than figuring out if Gerd 
> is also doing one more pull (but of course, if he does, it doesn't hurt; 
> git handles patches on multiple merge branches just fine, or I can 
> rebase it out of mine if Gerd's tree goes in first).
> 
> Queued:
> 
> git://repo.or.cz/qemu/ericb.git qapi
> http://repo.or.cz/qemu/ericb.git/shortlog/refs/heads/qapi

Removed from my QAPI queue; Gerd picked it up in his PR:
https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg03266.html

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

      reply	other threads:[~2018-03-12 15:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-05 16:37 [Qemu-devel] [PATCH v4] qapi: Add device ID and head parameters to screendump Thomas Huth
2018-03-05 16:50 ` Eric Blake
2018-03-06  9:01   ` Thomas Huth
2018-03-11  3:05 ` Eric Blake
2018-03-12 15:00   ` Eric Blake [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4c8a7a8-9b2b-1dbc-0cd4-005c8784df0f@redhat.com \
    --to=eblake@redhat.com \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=jdenemar@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).