From: Paolo Bonzini <pbonzini@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org
Cc: Igor Mammedov <imammedo@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
Juan Quintela <quintela@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
lersek@redhat.com
Subject: Re: [Qemu-devel] [PATCH 3/3] memory-mapping: skip non-volatile memory regions in GuestPhysBlockList
Date: Mon, 29 Oct 2018 10:50:31 +0100 [thread overview]
Message-ID: <f4e920ad-e51a-6783-0522-6ed5f0351ca0@redhat.com> (raw)
In-Reply-To: <20181003114454.5662-4-marcandre.lureau@redhat.com>
On 03/10/2018 13:44, Marc-André Lureau wrote:
> diff --git a/memory_mapping.c b/memory_mapping.c
> index 775466f3a8..724dd0b417 100644
> --- a/memory_mapping.c
> +++ b/memory_mapping.c
> @@ -206,7 +206,8 @@ static void guest_phys_blocks_region_add(MemoryListener *listener,
>
> /* we only care about RAM */
> if (!memory_region_is_ram(section->mr) ||
> - memory_region_is_ram_device(section->mr)) {
> + memory_region_is_ram_device(section->mr) ||
> + memory_region_is_nonvolatile(section->mr)) {
> return;
> }
>
We should also have
diff --git a/scripts/dump-guest-memory.py b/scripts/dump-guest-memory.py
index 5a857cebcf..dd180b531c 100644
--- a/scripts/dump-guest-memory.py
+++ b/scripts/dump-guest-memory.py
@@ -417,7 +417,9 @@ def get_guest_phys_blocks():
memory_region = flat_range["mr"].dereference()
# we only care about RAM
- if not memory_region["ram"]:
+ if not memory_region["ram"] \
+ or memory_region["ram_device"] \
+ or memory_region["nonvolatile"]:
continue
section_size = int128_get64(flat_range["addr"]["size"])
here. I queued the patches and will post this soon as a separate patch.
Paolo
next prev parent reply other threads:[~2018-10-29 9:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 11:44 [Qemu-devel] [PATCH 0/3] Mark non-volatile memory regions Marc-André Lureau
2018-10-03 11:44 ` [Qemu-devel] [PATCH 1/3] memory: learn about non-volatile memory region Marc-André Lureau
2018-10-03 11:44 ` [Qemu-devel] [PATCH 2/3] nvdimm: set non-volatile on the " Marc-André Lureau
2018-10-03 11:44 ` [Qemu-devel] [PATCH 3/3] memory-mapping: skip non-volatile memory regions in GuestPhysBlockList Marc-André Lureau
2018-10-03 13:54 ` Laszlo Ersek
2018-10-10 9:44 ` Dr. David Alan Gilbert
2018-10-10 9:49 ` David Hildenbrand
2018-10-29 9:50 ` Paolo Bonzini [this message]
2018-11-05 15:17 ` Laszlo Ersek
2018-10-29 9:03 ` [Qemu-devel] [PATCH 0/3] Mark non-volatile memory regions Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4e920ad-e51a-6783-0522-6ed5f0351ca0@redhat.com \
--to=pbonzini@redhat.com \
--cc=dgilbert@redhat.com \
--cc=imammedo@redhat.com \
--cc=lersek@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).