From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46071)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hps@selasky.org>) id 1bbth1-0003YW-2y
	for qemu-devel@nongnu.org; Mon, 22 Aug 2016 14:11:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hps@selasky.org>) id 1bbtgw-0004ci-Os
	for qemu-devel@nongnu.org; Mon, 22 Aug 2016 14:11:25 -0400
Received: from heidi.turbocat.net ([88.198.202.214]:50807
	helo=mail.turbocat.net) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hps@selasky.org>) id 1bbtgw-0004cU-IE
	for qemu-devel@nongnu.org; Mon, 22 Aug 2016 14:11:22 -0400
Received: from laptop015.home.selasky.org (unknown [62.141.129.119])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by mail.turbocat.net (Postfix) with ESMTPSA id 8C7021FE023
	for <qemu-devel@nongnu.org>; Mon, 22 Aug 2016 20:11:20 +0200 (CEST)
References: <90075d89-5c04-d419-9f98-7d9bc70555d3@selasky.org>
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <f4fd0eab-2cdb-0ca4-9ef1-08cf50b356a8@selasky.org>
Date: Mon, 22 Aug 2016 20:15:51 +0200
MIME-Version: 1.0
In-Reply-To: <90075d89-5c04-d419-9f98-7d9bc70555d3@selasky.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] QEMU XHCI support (FreeBSD)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Hi,

I'm currently testing QEMUs XHCI support with FreeBSD and found some 
bugs in FreeBSDs XHCI aswell as QEMUs XHCI.

1) QEMU falsely reports a remainder of 8 bytes on TR_SETUP. This patch 
fixes it. Can it be upstreamed?

--- ./work/qemu-2.3.0/hw/usb/hcd-xhci.c.orig	2016-08-22 
16:07:30.877585000 +0200
+++ ./work/qemu-2.3.0/hw/usb/hcd-xhci.c	2016-08-22 16:08:19.240109000 +0200
@@ -1748,6 +1748,11 @@ static void xhci_xfer_report(XHCITransfe
           unsigned int chunk = 0;

           switch (TRB_TYPE(*trb)) {
+        case TR_SETUP:
+            chunk = trb->status & 0x1ffff;
+            if (chunk > 8)
+                chunk = 8;
+            break;
           case TR_DATA:
           case TR_NORMAL:
           case TR_ISOCH:

Please CC me. I'm not subscribed.

--HPS