From: Jason Wang <jasowang@redhat.com>
To: Li Qiang <liq3ea@163.com>,
dmitry.fleytman@gmail.com, kraxel@redhat.com,
pbonzini@redhat.com, berrange@redhat.com, ehabkost@redhat.com,
alxndr@bu.edu, peter.maydell@linaro.org, f4bug@amsat.org
Cc: liq3ea@gmail.com, qemu-devel@nongnu.org
Subject: Re: [RFC 0/4] Add a 'in_mmio' device flag to avoid the DMA to MMIO
Date: Wed, 9 Sep 2020 10:16:48 +0800 [thread overview]
Message-ID: <f50624b9-dac7-c6ab-cce9-71cd9de477e1@redhat.com> (raw)
In-Reply-To: <20200908164157.47108-1-liq3ea@163.com>
On 2020/9/9 上午12:41, Li Qiang wrote:
> Currently the qemu device fuzzer find some DMA to MMIO issue. If the
> device handling MMIO currently trigger a DMA which the address is MMIO,
> this will reenter the device MMIO handler. As some of the device doesn't
> consider this it will sometimes crash the qemu.
>
> This patch tries to solve this by adding a per-device flag 'in_mmio'.
> When the memory core dispatch MMIO it will check/set this flag and when
> it leaves it will clean this flag.
What's the plan for fixing the irq issues pointed out by Peter?
Thanks
>
>
> Li Qiang (4):
> memory: add memory_region_init_io_with_dev interface
> memory: avoid reenter the device's MMIO handler while processing MMIO
> e1000e: use the new memory_region_init_io_with_dev interface
> hcd-xhci: use the new memory_region_init_io_with_dev interface
>
> hw/net/e1000e.c | 8 ++++----
> hw/usb/hcd-xhci.c | 25 ++++++++++++++---------
> include/exec/memory.h | 9 +++++++++
> include/hw/qdev-core.h | 1 +
> softmmu/memory.c | 46 +++++++++++++++++++++++++++++++++++++++---
> 5 files changed, 72 insertions(+), 17 deletions(-)
>
next prev parent reply other threads:[~2020-09-09 2:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 16:41 [RFC 0/4] Add a 'in_mmio' device flag to avoid the DMA to MMIO Li Qiang
2020-09-08 16:41 ` [RFC 1/4] memory: add memory_region_init_io_with_dev interface Li Qiang
2020-09-09 2:15 ` Jason Wang
2020-09-09 4:45 ` Li Qiang
2020-09-09 4:48 ` Gerd Hoffmann
2020-09-09 4:58 ` Li Qiang
2020-09-09 14:28 ` Alexander Bulekov
2020-09-10 14:37 ` Li Qiang
2020-09-14 2:37 ` Jason Wang
2020-09-20 7:55 ` Paolo Bonzini
2020-09-08 16:41 ` [RFC 2/4] memory: avoid reenter the device's MMIO handler while processing MMIO Li Qiang
2020-09-08 16:41 ` [RFC 3/4] e1000e: use the new memory_region_init_io_with_dev interface Li Qiang
2020-09-08 16:41 ` [RFC 4/4] hcd-xhci: " Li Qiang
2020-09-09 2:16 ` Jason Wang [this message]
2020-09-09 4:39 ` [RFC 0/4] Add a 'in_mmio' device flag to avoid the DMA to MMIO Li Qiang
2020-09-20 7:56 ` Paolo Bonzini
2020-09-20 20:24 ` Peter Maydell
2020-09-21 4:39 ` Li Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f50624b9-dac7-c6ab-cce9-71cd9de477e1@redhat.com \
--to=jasowang@redhat.com \
--cc=alxndr@bu.edu \
--cc=berrange@redhat.com \
--cc=dmitry.fleytman@gmail.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=kraxel@redhat.com \
--cc=liq3ea@163.com \
--cc=liq3ea@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).