From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org, omar.rizwan@gmail.com
Cc: peter.maydell@linaro.org, famz@redhat.com,
Andrew.Baumann@microsoft.com, qemu-arm@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] raspi: Add Raspberry Pi 1 support
Date: Wed, 12 Apr 2017 19:04:33 -0500 [thread overview]
Message-ID: <f52ad9a6-c3e7-4823-c21c-091809780341@redhat.com> (raw)
In-Reply-To: <149204143506.10500.9312462203357418218@6c512846dbc7>
[-- Attachment #1: Type: text/plain, Size: 840 bytes --]
On 04/12/2017 06:57 PM, no-reply@patchew.org wrote:
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
> === OUTPUT BEGIN ===
> Checking PATCH 1/1: raspi: Add Raspberry Pi 1 support...
> ERROR: line over 90 characters
> #189: FILE: hw/arm/raspi.c:34:
> + * https://github.com/AndrewFromMelbourne/raspberry_pi_revision/blob/2764c19983fb7b1ef8cb21031e94c293703afa2e/README.md
You can shorten this:
https://github.com/AndrewFromMelbourne/raspberry_pi_revision/blob/2764c199/README.md
to fit under 90, while still resolving to the same place (collisions
with just an 8-char prefix are rare enough to generally not be an issue
to git)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-04-13 0:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-08 5:43 [Qemu-devel] [PATCH] raspi: Add Raspberry Pi 1 support Omar Rizwan
2017-04-08 5:57 ` Andrew Baumann
2017-04-08 6:13 ` Omar Rizwan
2017-04-10 17:04 ` Andrew Baumann
2017-04-10 17:08 ` Andrew Baumann
2017-04-12 23:57 ` no-reply
2017-04-13 0:04 ` Eric Blake [this message]
2017-04-20 13:20 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f52ad9a6-c3e7-4823-c21c-091809780341@redhat.com \
--to=eblake@redhat.com \
--cc=Andrew.Baumann@microsoft.com \
--cc=famz@redhat.com \
--cc=omar.rizwan@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).