Re: [PATCH v2 18/37] target/sparc: Implement FPADDS, FPSUBS

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 26/5/24 21:42, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   target/sparc/insns.decode |  9 +++++
>   target/sparc/translate.c  | 82 +++++++++++++++++++++++++++++++++++++++
>   2 files changed, 91 insertions(+)


> +static void gen_op_fpadds16s(TCGv_i32 d, TCGv_i32 src1, TCGv_i32 src2)
> +{
> +    TCGv_i32 t[2];
> +
> +    for (int i = 0; i < 2; i++) {
> +        TCGv_i32 u = tcg_temp_new_i32();
> +        TCGv_i32 v = tcg_temp_new_i32();
> +
> +        tcg_gen_sextract_i32(u, src1, i * 16, 16);
> +        tcg_gen_sextract_i32(v, src2, i * 16, 16);
> +        tcg_gen_add_i32(u, u, v);
> +        tcg_gen_smax_i32(u, u, tcg_constant_i32(INT16_MIN));
> +        tcg_gen_smin_i32(u, u, tcg_constant_i32(INT16_MAX));
> +        t[i] = u;
> +    }
> +    tcg_gen_deposit_i32(d, t[0], t[1], 16, 16);
> +}
> +
> +static void gen_op_fpsubs16s(TCGv_i32 d, TCGv_i32 src1, TCGv_i32 src2)
> +{
> +    TCGv_i32 t[2];
> +
> +    for (int i = 0; i < 2; i++) {
> +        TCGv_i32 u = tcg_temp_new_i32();
> +        TCGv_i32 v = tcg_temp_new_i32();
> +
> +        tcg_gen_sextract_i32(u, src1, i * 16, 16);
> +        tcg_gen_sextract_i32(v, src2, i * 16, 16);
> +        tcg_gen_sub_i32(u, u, v);

I wondered about passing add/sub functions as argument, but well...

> +        tcg_gen_smax_i32(u, u, tcg_constant_i32(INT16_MIN));
> +        tcg_gen_smin_i32(u, u, tcg_constant_i32(INT16_MAX));
> +        t[i] = u;
> +    }
> +    tcg_gen_deposit_i32(d, t[0], t[1], 16, 16);
> +}

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>