From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: shentey@gmail.com
Subject: Re: [PATCH v2 5/8] isa: specify instance_size in isa_superio_type_info
Date: Wed, 7 Feb 2024 20:03:30 +0100 [thread overview]
Message-ID: <f53b1dc9-779a-4166-878e-42fd7889cc6f@linaro.org> (raw)
In-Reply-To: <20240207111411.115040-6-pbonzini@redhat.com>
On 7/2/24 12:14, Paolo Bonzini wrote:
> Right now all subclasses of TYPE_ISA_SUPERIO have to specify an instance_size,
> because the ISASuperIODevice struct adds fields to ISADevice but the type does
> not include the increased instance size. Failure to do so results in an access
> past the bounds of struct ISADevice as soon as isa_superio_realize is called.
> Fix this by specifying the instance_size already in the superclass.
>
> Cc: Bernhard Beschow <shentey@gmail.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/isa/isa-superio.c | 2 +-
> hw/isa/smc37c669-superio.c | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
Oops, thanks!
Fixes: 4c3119a6e3 ("hw/isa/superio: Factor out the parallel code from
pc87312.c")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-02-07 19:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 11:14 [PATCH v2 0/8] mips: do not list individual devices from configs/ Paolo Bonzini
2024-02-07 11:14 ` [PATCH v2 1/8] usb: inline device creation functions Paolo Bonzini
2024-02-07 11:14 ` [PATCH v2 2/8] isa: clean up Kconfig selections for ISA_SUPERIO Paolo Bonzini
2024-02-07 11:14 ` [PATCH v2 3/8] hw/mips/Kconfig: Remove ISA dependencies from MIPSsim board Paolo Bonzini
2024-02-07 18:58 ` Philippe Mathieu-Daudé
2024-02-08 8:11 ` Paolo Bonzini
2024-02-09 12:43 ` Philippe Mathieu-Daudé
2024-02-07 11:14 ` [PATCH v2 4/8] isa: fix ISA_SUPERIO dependencies Paolo Bonzini
2024-02-07 13:09 ` BALATON Zoltan
2024-02-07 19:01 ` Philippe Mathieu-Daudé
2024-02-08 16:18 ` Bernhard Beschow
2024-02-07 11:14 ` [PATCH v2 5/8] isa: specify instance_size in isa_superio_type_info Paolo Bonzini
2024-02-07 19:03 ` Philippe Mathieu-Daudé [this message]
2024-02-08 16:10 ` Bernhard Beschow
2024-02-07 11:14 ` [PATCH v2 6/8] isa: extract FDC37M81X to a separate file Paolo Bonzini
2024-02-07 13:13 ` BALATON Zoltan
2024-02-08 16:14 ` Bernhard Beschow
2024-02-07 11:14 ` [PATCH v2 7/8] mips: allow compiling out CONFIG_MIPS_ITU Paolo Bonzini
2024-02-07 13:15 ` BALATON Zoltan
2024-02-07 13:56 ` Paolo Bonzini
2024-02-07 19:12 ` Philippe Mathieu-Daudé
2024-02-08 8:26 ` Paolo Bonzini
2024-02-09 7:22 ` Philippe Mathieu-Daudé
2024-02-09 9:15 ` Philippe Mathieu-Daudé
2024-02-07 11:14 ` [PATCH v2 8/8] mips: do not list individual devices from configs/ Paolo Bonzini
2024-02-07 13:18 ` BALATON Zoltan
2024-02-07 13:55 ` Paolo Bonzini
2024-02-08 16:16 ` Bernhard Beschow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f53b1dc9-779a-4166-878e-42fd7889cc6f@linaro.org \
--to=philmd@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=shentey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).