From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fY7VJ-0003Am-Ay for qemu-devel@nongnu.org; Wed, 27 Jun 2018 06:16:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fY7VE-0007OV-Ow for qemu-devel@nongnu.org; Wed, 27 Jun 2018 06:16:49 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:46352 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fY7VE-0007O6-Jv for qemu-devel@nongnu.org; Wed, 27 Jun 2018 06:16:44 -0400 From: Thomas Huth References: <1526977831-31129-1-git-send-email-thuth@redhat.com> Message-ID: Date: Wed, 27 Jun 2018 12:16:41 +0200 MIME-Version: 1.0 In-Reply-To: <1526977831-31129-1-git-send-email-thuth@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] tests/boot-serial: Do not delete the output file in case of errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Paolo Bonzini Cc: Mark Cave-Ayland , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Peter Maydell On 22.05.2018 10:30, Thomas Huth wrote: > Peter reported that the boot-serial tester sometimes runs into timeouts > with SPARC guests. It's currently completely unclear whether this is due > to too much load on the host machine (so that the guest really just ran > too slow), or whether there is something wrong with the guest's firmware > boot. For further debugging, we need the serial output of the guest in > case of errors, so instead of unlinking the file immediately, this is > now only done in case of success. In case of error, print the name of the > file with the serial output via g_error() (which then also calls abort() > internally to mark the test as failed). > > Signed-off-by: Thomas Huth > --- > tests/boot-serial-test.c | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) Ping! Paolo, could you take this patch through your misc / character devices tree, please? Thanks, Thomas