From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: Pierrick Bouvier <pierrick.bouvier@linaro.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Anton Johansson <anjo@rev.ng>
Subject: Re: [PATCH v2 5/7] target/microblaze: Have compute_ldst_addr_type[ab] return TCG_i32
Date: Wed, 15 Oct 2025 19:59:40 +0200 [thread overview]
Message-ID: <f55ffd33-e746-48c7-9faa-94ccaa4f4be6@linaro.org> (raw)
In-Reply-To: <20251015175717.93945-6-philmd@linaro.org>
On 15/10/25 19:57, Philippe Mathieu-Daudé wrote:
> Both compute_ldst_addr_typea() and compute_ldst_addr_typeb()
> bodies use a TCG_i32, so return the same type.
>
> Suggested-by: Anton Johansson <anjo@rev.ng>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/microblaze/translate.c | 48 +++++++++++++++++------------------
> 1 file changed, 24 insertions(+), 24 deletions(-)
>
> diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
> index bc38ff0af92..002f921e00f 100644
> --- a/target/microblaze/translate.c
> +++ b/target/microblaze/translate.c
> @@ -604,7 +604,7 @@ static bool trans_wdic(DisasContext *dc, arg_wdic *a)
> DO_TYPEA(xor, false, tcg_gen_xor_i32)
> DO_TYPEBI(xori, false, tcg_gen_xori_i32)
>
> -static TCGv compute_ldst_addr_typea(DisasContext *dc, int ra, int rb)
> +static TCG_i32 compute_ldst_addr_typea(DisasContext *dc, int ra, int rb)
> {
s/TCG_i32/TCGv_i32/ 🤦
next prev parent reply other threads:[~2025-10-15 18:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 17:57 [PATCH v2 0/7] target/microblaze: Remove all uses of target_ulong type Philippe Mathieu-Daudé
2025-10-15 17:57 ` [PATCH v2 1/7] target/microblaze: Remove target_ulong use in cpu_handle_mmu_fault() Philippe Mathieu-Daudé
2025-10-15 17:57 ` [PATCH v2 2/7] target/microblaze: Remove target_ulong uses in get_phys_page_attrs_debug Philippe Mathieu-Daudé
2025-10-15 17:57 ` [PATCH v2 3/7] target/microblaze: Remove target_ulong use in gen_goto_tb() Philippe Mathieu-Daudé
2025-10-15 17:57 ` [PATCH v2 4/7] target/microblaze: Remove target_ulong use in helper_stackprot() Philippe Mathieu-Daudé
2025-10-15 17:57 ` [PATCH v2 5/7] target/microblaze: Have compute_ldst_addr_type[ab] return TCG_i32 Philippe Mathieu-Daudé
2025-10-15 17:59 ` Philippe Mathieu-Daudé [this message]
2025-10-15 17:57 ` [PATCH v2 6/7] target/microblaze: Have do_load/store() take a TCG_i32 address argument Philippe Mathieu-Daudé
2025-10-15 17:57 ` [PATCH v2 7/7] target/microblaze: Convert CPUMBState::res_addr field to uint32_t type Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f55ffd33-e746-48c7-9faa-94ccaa4f4be6@linaro.org \
--to=philmd@linaro.org \
--cc=anjo@rev.ng \
--cc=edgar.iglesias@gmail.com \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).