From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58676) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCN9h-0006fE-UO for qemu-devel@nongnu.org; Mon, 13 Jun 2016 04:23:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCN9h-0002I9-3I for qemu-devel@nongnu.org; Mon, 13 Jun 2016 04:23:33 -0400 References: <1465575999-3594234-1-git-send-email-afarallax@yandex.ru> <1465575999-3594234-2-git-send-email-afarallax@yandex.ru> <4506161465576922@web25g.yandex.ru> <4790101465579571@web25h.yandex.ru> From: Paolo Bonzini Message-ID: Date: Mon, 13 Jun 2016 10:23:13 +0200 MIME-Version: 1.0 In-Reply-To: <4790101465579571@web25h.yandex.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] Fix confusing argument names of do_unaligned_access() functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sergey Sorokin , Peter Maydell Cc: QEMU Developers , Peter Crosthwaite , Richard Henderson , "Edgar E. Iglesias" , Eduardo Habkost , Michael Walle , Aurelien Jarno , Leon Alrae , Anthony Green , Jia Liu , David Gibson , Alexander Graf , Blue Swirl , Mark Cave-Ayland , Bastian Koppelmann , Guan Xuetao , Max Filippov , qemu-arm , "qemu-ppc@nongnu.org" On 10/06/2016 19:26, Sergey Sorokin wrote: > cpu-common.h is not included in qom/cpu.h what do you think? Should > it be included? Or may be MMUAccessType should be just moved into > another header. For example into exec/memattrs.h You can move it to qom/cpu.h. Paolo