qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Patrick Leis <venture@google.com>,
	clg@kaod.org, peter.maydell@linaro.org,
	steven_lee@aspeedtech.com, leetroy@gmail.co,
	jamin_lin@aspeedtech.com, andrew@codeconstruct.com.au,
	joel@jms.id.au
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/arm: enable at24c with aspeed
Date: Tue, 29 Oct 2024 01:58:41 -0300	[thread overview]
Message-ID: <f58d7435-c329-4961-a461-9242a4e89366@linaro.org> (raw)
In-Reply-To: <20241028181420.1438938-1-venture@google.com>

On 28/10/24 15:14, Patrick Leis wrote:
> Enable AT24C with ASPEED in the KConfig because the boards build this
> device.

Maybe explicit the at24c_eeprom_init_rom() call which instanciate
TYPE_AT24C_EE.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

> 
> Signed-off-by: Patrick Leis <venture@google.com>
> ---
>   hw/arm/Kconfig | 1 +
>   1 file changed, 1 insertion(+)



  parent reply	other threads:[~2024-10-29  4:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-28 18:14 [PATCH] hw/arm: enable at24c with aspeed Patrick Leis
2024-10-28 18:19 ` Hao Wu
2024-10-29  0:43 ` Andrew Jeffery
2024-10-29  4:58 ` Philippe Mathieu-Daudé [this message]
2024-11-02 14:58 ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f58d7435-c329-4961-a461-9242a4e89366@linaro.org \
    --to=philmd@linaro.org \
    --cc=andrew@codeconstruct.com.au \
    --cc=clg@kaod.org \
    --cc=jamin_lin@aspeedtech.com \
    --cc=joel@jms.id.au \
    --cc=leetroy@gmail.co \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=steven_lee@aspeedtech.com \
    --cc=venture@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).