[PATCH] hw/arm: enable at24c with aspeed

[PATCH] hw/arm: enable at24c with aspeed

[Patrick Leis]

Enable AT24C with ASPEED in the KConfig because the boards build this
device.

Signed-off-by: Patrick Leis <venture@google.com>
---
 hw/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index e7fd9338d1..1b25e73578 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -539,6 +539,7 @@ config ASPEED_SOC
     select PMBUS
     select MAX31785
     select FSI_APB2OPB_ASPEED
+    select AT24C
 
 config MPS2
     bool
-- 
2.47.0.163.g1226f6d8fa-goog

Re: [PATCH] hw/arm: enable at24c with aspeed

[Hao Wu]

[-- Attachment #1: Type: text/plain, Size: 690 bytes --]

On Mon, Oct 28, 2024 at 11:15 AM Patrick Leis <venture@google.com> wrote:

> Enable AT24C with ASPEED in the KConfig because the boards build this
> device.
>
> Signed-off-by: Patrick Leis <venture@google.com>
>
Reviewed-by: Hao Wu <wuhaotsh@google.com>

> ---
>  hw/arm/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> index e7fd9338d1..1b25e73578 100644
> --- a/hw/arm/Kconfig
> +++ b/hw/arm/Kconfig
> @@ -539,6 +539,7 @@ config ASPEED_SOC
>      select PMBUS
>      select MAX31785
>      select FSI_APB2OPB_ASPEED
> +    select AT24C
>
>  config MPS2
>      bool
> --
> 2.47.0.163.g1226f6d8fa-goog
>
>
>

[-- Attachment #2: Type: text/html, Size: 1310 bytes --]

Re: [PATCH] hw/arm: enable at24c with aspeed

[Andrew Jeffery]

On Mon, 2024-10-28 at 18:14 +0000, Patrick Leis wrote:
> Enable AT24C with ASPEED in the KConfig because the boards build this
> device.
> 
> Signed-off-by: Patrick Leis <venture@google.com>

I was wondering how we haven't hit problems before now. Poking around
with scripts/minikconf.py for an arm-softmmu build we get:

   # config AT24C depends on I2C
   # select AT24C if NPCM7XX
   # => AT24C is now True
   # config AT24C default y if E500
   # config AT24C default n

Seems reasonable that the Aspeed models should select it themselves
given they depend on the symbols.

Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>

Re: [PATCH] hw/arm: enable at24c with aspeed

[Philippe Mathieu-Daudé]

On 28/10/24 15:14, Patrick Leis wrote:
> Enable AT24C with ASPEED in the KConfig because the boards build this
> device.

Maybe explicit the at24c_eeprom_init_rom() call which instanciate
TYPE_AT24C_EE.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

> 
> Signed-off-by: Patrick Leis <venture@google.com>
> ---
>   hw/arm/Kconfig | 1 +
>   1 file changed, 1 insertion(+)

Re: [PATCH] hw/arm: enable at24c with aspeed

[Cédric Le Goater]

On 10/28/24 19:14, Patrick Leis wrote:
> Enable AT24C with ASPEED in the KConfig because the boards build this
> device.
> 
> Signed-off-by: Patrick Leis <venture@google.com>
> ---
>   hw/arm/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> index e7fd9338d1..1b25e73578 100644
> --- a/hw/arm/Kconfig
> +++ b/hw/arm/Kconfig
> @@ -539,6 +539,7 @@ config ASPEED_SOC
>       select PMBUS
>       select MAX31785
>       select FSI_APB2OPB_ASPEED
> +    select AT24C
>   
>   config MPS2
>       bool


Applied to aspeed-next.

Thanks,

C.