From: Richard Henderson <richard.henderson@linaro.org>
To: BALATON Zoltan <balaton@eik.bme.hu>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Magnus Damm <magnus.damm@gmail.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: Re: [PATCH 3/6] hw/sh4: Change debug printfs to traces
Date: Tue, 26 Oct 2021 19:13:59 -0700 [thread overview]
Message-ID: <f595e837-4245-1492-8abd-16dabdb06571@linaro.org> (raw)
In-Reply-To: <031a5111bb1ef1e66fd8f05fbe4a5ecbbcb25396.1635298341.git.balaton@eik.bme.hu>
On 10/26/21 6:32 PM, BALATON Zoltan wrote:
> + trace_sh_serial("write", size, offs, val);
> switch (offs) {
> case 0x00: /* SMR */
> s->smr = val & ((s->feat & SH_SERIAL_FEAT_SCIF) ? 0x7b : 0xff);
> @@ -302,10 +298,7 @@ static uint64_t sh_serial_read(void *opaque, hwaddr offs,
> break;
> }
> }
> -#ifdef DEBUG_SERIAL
> - printf("sh_serial: read offs=0x%02x val=0x%x\n",
> - offs, ret);
> -#endif
> + trace_sh_serial("read ", size, offs, ret);
I suggest two separate sh_serial_{read,write} tracepoints.
r~
next prev parent reply other threads:[~2021-10-27 2:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 1:32 [PATCH 0/6] More SH4 clean ups BALATON Zoltan
2021-10-27 1:32 ` [PATCH 1/6] hw/sh4: Fix a typo in a comment BALATON Zoltan
2021-10-27 2:10 ` Richard Henderson
2021-10-27 1:32 ` [PATCH 4/6] hw/sh4/r2d: Use error_report instead of fprintf to stderr BALATON Zoltan
2021-10-27 2:19 ` Richard Henderson
2021-10-27 1:32 ` [PATCH 6/6] hw/char/sh_serial: Add device id to trace output BALATON Zoltan
2021-10-27 1:32 ` [PATCH 5/6] hw/char/sh_serial: QOM-ify BALATON Zoltan
2021-10-27 1:32 ` [PATCH 3/6] hw/sh4: Change debug printfs to traces BALATON Zoltan
2021-10-27 2:13 ` Richard Henderson [this message]
2021-10-27 9:40 ` BALATON Zoltan
2021-10-27 15:38 ` Richard Henderson
2021-10-27 1:32 ` [PATCH 2/6] hw//sh4: Use qemu_log instead of fprintf to stderr BALATON Zoltan
2021-10-27 2:12 ` Richard Henderson
2021-10-27 4:10 ` [PATCH 0/6] More SH4 clean ups Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f595e837-4245-1492-8abd-16dabdb06571@linaro.org \
--to=richard.henderson@linaro.org \
--cc=balaton@eik.bme.hu \
--cc=magnus.damm@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).