Re: [PATCH v2 2/2] tests/lcitool: Add mtools and xorriso and remove genisoimage as dependencies

[Thomas Huth <thuth@redhat.com>]

On 04/05/2023 17.46, Ani Sinha wrote:
> Bios bits avocado tests need mformat (provided by the mtools package) and
> xorriso tools in order to run within gitlab CI containers. Add those
> dependencies within the Dockerfiles so that containers can be built with
> those tools present and bios bits avocado tests can be run there.
> 
> xorriso package conflicts with genisoimage package on some distributions.
> Therefore, it is not possible to have both the packages at the same time
> in the container image uniformly for all distribution flavors. Further,
> on some distributions like RHEL, both xorriso and genisoimage
> packages provide /usr/bin/genisoimage and on some other distributions like
> Fedora, only genisoimage package provides the same utility.
> Therefore, this change removes the dependency on geninsoimage for building
> container images altogether keeping only xorriso package. At the same time,
> cdrom-test.c is updated to use and check for existence of only xorrisofs.
> 
> CC: mst@redhat.com
> CC: berrange@redhat.com
> Signed-off-by: Ani Sinha <anisinha@redhat.com>
> ---


Reviewed-by: Thomas Huth <thuth@redhat.com>