* [PATCH v2 0/2] tests/lcitool: Add mtools and xorriso and remove genisoimage as dependencies
@ 2023-05-04 15:46 Ani Sinha
2023-05-04 15:46 ` [PATCH v2 1/2] tests: libvirt-ci: Update to commit 'c8971e90ac' to pull in mformat and xorriso Ani Sinha
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Ani Sinha @ 2023-05-04 15:46 UTC (permalink / raw)
To: qemu-devel
Cc: Ani Sinha, mst, berrange, alex.bennee, philmd, wainersm, bleal,
thuth
mformat and xorriso tools are needed by biosbits avocado tests. This patchset
adds those two tools in the docker container images.
xorriso package conflicts with genisoimage package on some distributions.
Therefore, it is not possible to have both the packages at the same time
in the container image uniformly for all distribution flavors. Further,
on some distributions like RHEL, both xorriso and genisoimage
packages provide /usr/bin/genisoimage and on some other distributions like
Fedora, only genisoimage package provides the same utility.
Therefore, this change removes the dependency on geninsoimage for building
container images altogether keeping only xorriso package. At the same time,
cdrom-test.c is updated to use and check for existence of only xorrisofs.
Patch 1 pulls in the latest changes in lcitool in order to add mappings
for these packages in various distros.
Patch 2 updates all Dockerfiles in QEMU repository to add these two
tools. It also removed genisoimage package and updated cdrom-test to not
use genisoimage but xorrisofs.
CC: mst@redhat.com
CC: berrange@redhat.com
CC: alex.bennee@linaro.org
CC: philmd@linaro.org
CC: wainersm@redhat.com
CC: bleal@redhat.com
CC: thuth@redhat.com
TO: qemu-devel@nongnu.org
Changelog:
v2: remove genisoimage package and update Dockerfile. Also update cdrom-test.c
so that it uses xorrisofs and not genisoimage. I have tested patch #2 on both
Fedora 37 and RHEL 9.1. cdrom-test passed on both.
Ani Sinha (2):
tests: libvirt-ci: Update to commit 'c8971e90ac' to pull in mformat
and xorriso
tests/lcitool: Add mtools and xorriso and remove genisoimage as
dependencies
.gitlab-ci.d/cirrus/freebsd-13.vars | 2 +-
.gitlab-ci.d/cirrus/macos-12.vars | 2 +-
tests/docker/dockerfiles/alpine.docker | 3 ++-
tests/docker/dockerfiles/centos8.docker | 3 ++-
tests/docker/dockerfiles/debian-amd64-cross.docker | 3 ++-
tests/docker/dockerfiles/debian-amd64.docker | 3 ++-
tests/docker/dockerfiles/debian-arm64-cross.docker | 3 ++-
tests/docker/dockerfiles/debian-armel-cross.docker | 3 ++-
tests/docker/dockerfiles/debian-armhf-cross.docker | 3 ++-
.../dockerfiles/debian-mips64el-cross.docker | 3 ++-
.../docker/dockerfiles/debian-mipsel-cross.docker | 3 ++-
.../docker/dockerfiles/debian-ppc64el-cross.docker | 3 ++-
tests/docker/dockerfiles/debian-s390x-cross.docker | 3 ++-
tests/docker/dockerfiles/fedora-win32-cross.docker | 3 ++-
tests/docker/dockerfiles/fedora-win64-cross.docker | 3 ++-
tests/docker/dockerfiles/fedora.docker | 3 ++-
tests/docker/dockerfiles/opensuse-leap.docker | 3 ++-
tests/docker/dockerfiles/ubuntu2004.docker | 3 ++-
tests/docker/dockerfiles/ubuntu2204.docker | 3 ++-
tests/lcitool/libvirt-ci | 2 +-
tests/lcitool/projects/qemu.yml | 3 ++-
tests/qtest/cdrom-test.c | 14 +++++++-------
22 files changed, 46 insertions(+), 28 deletions(-)
--
2.31.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/2] tests: libvirt-ci: Update to commit 'c8971e90ac' to pull in mformat and xorriso
2023-05-04 15:46 [PATCH v2 0/2] tests/lcitool: Add mtools and xorriso and remove genisoimage as dependencies Ani Sinha
@ 2023-05-04 15:46 ` Ani Sinha
2023-05-04 17:17 ` Thomas Huth
2023-05-04 15:46 ` [PATCH v2 2/2] tests/lcitool: Add mtools and xorriso and remove genisoimage as dependencies Ani Sinha
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Ani Sinha @ 2023-05-04 15:46 UTC (permalink / raw)
To: qemu-devel, Alex Bennée, Philippe Mathieu-Daudé,
Thomas Huth, Wainer dos Santos Moschetta, Beraldo Leal
Cc: Ani Sinha, mst, berrange
Pull in the following changes from lcitool:
* tests/lcitool/libvirt-ci 85487e1...c8971e9 (18):
> mappings: add new package mappings for mformat and xorriso
> docs: testing: Update contents with tox
> .gitlab-ci.yml: Always test against installed lcitool
> gitlab-ci.yml: Start using tox for testing
> tox: Allow running with custom pytest options with {posargs}
> gitignore: Add the default .tox directory
> dev-requirements: Reference VM requirements
> requirements: Add tox to dev-requirements.txt and drop pytest and flake
> test-requirements: Rename to dev-requirements.txt
> Add tox.ini configuration file
> tests: commands: Consolidate the installed package/run from git tests
> Add a pytest.ini
> facts: targets: Drop Fedora 36 target
> gitlab-ci.yml: Add Fedora 38 target
> facts: targets: Add Fedora 38
> facts: mappings: Drop 'zstd' mapping
> facts: projects: nbdkit: Replace zstd mapping with libzstd
> docs: mappings: Add a section on the preferred mapping naming scheme
CC: mst@redhat.com
CC: berrange@redhat.com
Signed-off-by: Ani Sinha <anisinha@redhat.com>
---
tests/lcitool/libvirt-ci | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/lcitool/libvirt-ci b/tests/lcitool/libvirt-ci
index 85487e1404..c8971e90ac 160000
--- a/tests/lcitool/libvirt-ci
+++ b/tests/lcitool/libvirt-ci
@@ -1 +1 @@
-Subproject commit 85487e140415b2ac54b01a9a6b600fd7c21edc2f
+Subproject commit c8971e90ac169ee2b539c747f74d96c876debdf9
--
2.31.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 2/2] tests/lcitool: Add mtools and xorriso and remove genisoimage as dependencies
2023-05-04 15:46 [PATCH v2 0/2] tests/lcitool: Add mtools and xorriso and remove genisoimage as dependencies Ani Sinha
2023-05-04 15:46 ` [PATCH v2 1/2] tests: libvirt-ci: Update to commit 'c8971e90ac' to pull in mformat and xorriso Ani Sinha
@ 2023-05-04 15:46 ` Ani Sinha
2023-05-04 17:23 ` Thomas Huth
2023-05-04 16:27 ` [PATCH v2 0/2] " Ani Sinha
2023-05-09 16:16 ` Michael S. Tsirkin
3 siblings, 1 reply; 9+ messages in thread
From: Ani Sinha @ 2023-05-04 15:46 UTC (permalink / raw)
To: qemu-devel, Ed Maste, Li-Wen Hsu, Alex Bennée,
Philippe Mathieu-Daudé, Thomas Huth,
Wainer dos Santos Moschetta, Beraldo Leal, John Snow,
Laurent Vivier, Paolo Bonzini
Cc: Ani Sinha, mst, berrange, qemu-block
Bios bits avocado tests need mformat (provided by the mtools package) and
xorriso tools in order to run within gitlab CI containers. Add those
dependencies within the Dockerfiles so that containers can be built with
those tools present and bios bits avocado tests can be run there.
xorriso package conflicts with genisoimage package on some distributions.
Therefore, it is not possible to have both the packages at the same time
in the container image uniformly for all distribution flavors. Further,
on some distributions like RHEL, both xorriso and genisoimage
packages provide /usr/bin/genisoimage and on some other distributions like
Fedora, only genisoimage package provides the same utility.
Therefore, this change removes the dependency on geninsoimage for building
container images altogether keeping only xorriso package. At the same time,
cdrom-test.c is updated to use and check for existence of only xorrisofs.
CC: mst@redhat.com
CC: berrange@redhat.com
Signed-off-by: Ani Sinha <anisinha@redhat.com>
---
.gitlab-ci.d/cirrus/freebsd-13.vars | 2 +-
.gitlab-ci.d/cirrus/macos-12.vars | 2 +-
tests/docker/dockerfiles/alpine.docker | 3 ++-
tests/docker/dockerfiles/centos8.docker | 3 ++-
tests/docker/dockerfiles/debian-amd64-cross.docker | 3 ++-
tests/docker/dockerfiles/debian-amd64.docker | 3 ++-
tests/docker/dockerfiles/debian-arm64-cross.docker | 3 ++-
tests/docker/dockerfiles/debian-armel-cross.docker | 3 ++-
tests/docker/dockerfiles/debian-armhf-cross.docker | 3 ++-
.../dockerfiles/debian-mips64el-cross.docker | 3 ++-
.../docker/dockerfiles/debian-mipsel-cross.docker | 3 ++-
.../docker/dockerfiles/debian-ppc64el-cross.docker | 3 ++-
tests/docker/dockerfiles/debian-s390x-cross.docker | 3 ++-
tests/docker/dockerfiles/fedora-win32-cross.docker | 3 ++-
tests/docker/dockerfiles/fedora-win64-cross.docker | 3 ++-
tests/docker/dockerfiles/fedora.docker | 3 ++-
tests/docker/dockerfiles/opensuse-leap.docker | 3 ++-
tests/docker/dockerfiles/ubuntu2004.docker | 3 ++-
tests/docker/dockerfiles/ubuntu2204.docker | 3 ++-
tests/lcitool/projects/qemu.yml | 3 ++-
tests/qtest/cdrom-test.c | 14 +++++++-------
21 files changed, 45 insertions(+), 27 deletions(-)
diff --git a/.gitlab-ci.d/cirrus/freebsd-13.vars b/.gitlab-ci.d/cirrus/freebsd-13.vars
index 7622c849b2..facb649f5b 100644
--- a/.gitlab-ci.d/cirrus/freebsd-13.vars
+++ b/.gitlab-ci.d/cirrus/freebsd-13.vars
@@ -11,6 +11,6 @@ MAKE='/usr/local/bin/gmake'
NINJA='/usr/local/bin/ninja'
PACKAGING_COMMAND='pkg'
PIP3='/usr/local/bin/pip-3.8'
-PKGS='alsa-lib bash bison bzip2 ca_root_nss capstone4 ccache cdrkit-genisoimage cmocka ctags curl cyrus-sasl dbus diffutils dtc flex fusefs-libs3 gettext git glib gmake gnutls gsed gtk3 json-c libepoxy libffi libgcrypt libjpeg-turbo libnfs libslirp libspice-server libssh libtasn1 llvm lzo2 meson ncurses nettle ninja opencv pixman pkgconf png py39-numpy py39-pillow py39-pip py39-sphinx py39-sphinx_rtd_theme py39-yaml python3 rpm2cpio sdl2 sdl2_image snappy sndio socat spice-protocol tesseract usbredir virglrenderer vte3 zstd'
+PKGS='alsa-lib bash bison bzip2 ca_root_nss capstone4 ccache cmocka ctags curl cyrus-sasl dbus diffutils dtc flex fusefs-libs3 gettext git glib gmake gnutls gsed gtk3 json-c libepoxy libffi libgcrypt libjpeg-turbo libnfs libslirp libspice-server libssh libtasn1 llvm lzo2 meson mtools ncurses nettle ninja opencv pixman pkgconf png py39-numpy py39-pillow py39-pip py39-sphinx py39-sphinx_rtd_theme py39-yaml python3 rpm2cpio sdl2 sdl2_image snappy sndio socat spice-protocol tesseract usbredir virglrenderer vte3 xorriso zstd'
PYPI_PKGS=''
PYTHON='/usr/local/bin/python3'
diff --git a/.gitlab-ci.d/cirrus/macos-12.vars b/.gitlab-ci.d/cirrus/macos-12.vars
index da6aa6469b..ceb294e153 100644
--- a/.gitlab-ci.d/cirrus/macos-12.vars
+++ b/.gitlab-ci.d/cirrus/macos-12.vars
@@ -11,6 +11,6 @@ MAKE='/opt/homebrew/bin/gmake'
NINJA='/opt/homebrew/bin/ninja'
PACKAGING_COMMAND='brew'
PIP3='/opt/homebrew/bin/pip3'
-PKGS='bash bc bison bzip2 capstone ccache cmocka ctags curl dbus diffutils dtc flex gcovr gettext git glib gnu-sed gnutls gtk+3 jemalloc jpeg-turbo json-c libepoxy libffi libgcrypt libiscsi libnfs libpng libslirp libssh libtasn1 libusb llvm lzo make meson ncurses nettle ninja pixman pkg-config python3 rpm2cpio sdl2 sdl2_image snappy socat sparse spice-protocol tesseract usbredir vde vte3 zlib zstd'
+PKGS='bash bc bison bzip2 capstone ccache cmocka ctags curl dbus diffutils dtc flex gcovr gettext git glib gnu-sed gnutls gtk+3 jemalloc jpeg-turbo json-c libepoxy libffi libgcrypt libiscsi libnfs libpng libslirp libssh libtasn1 libusb llvm lzo make meson mtools ncurses nettle ninja pixman pkg-config python3 rpm2cpio sdl2 sdl2_image snappy socat sparse spice-protocol tesseract usbredir vde vte3 xorriso zlib zstd'
PYPI_PKGS='PyYAML numpy pillow sphinx sphinx-rtd-theme'
PYTHON='/opt/homebrew/bin/python3'
diff --git a/tests/docker/dockerfiles/alpine.docker b/tests/docker/dockerfiles/alpine.docker
index 81c70aeaf9..0097637dca 100644
--- a/tests/docker/dockerfiles/alpine.docker
+++ b/tests/docker/dockerfiles/alpine.docker
@@ -19,7 +19,6 @@ RUN apk update && \
ca-certificates \
capstone-dev \
ccache \
- cdrkit \
ceph-dev \
clang \
cmocka-dev \
@@ -67,6 +66,7 @@ RUN apk update && \
make \
mesa-dev \
meson \
+ mtools \
multipath-tools \
musl-dev \
ncurses-dev \
@@ -108,6 +108,7 @@ RUN apk update && \
which \
xen-dev \
xfsprogs-dev \
+ xorriso \
zlib-dev \
zlib-static \
zstd \
diff --git a/tests/docker/dockerfiles/centos8.docker b/tests/docker/dockerfiles/centos8.docker
index 1a6a9087c1..78f454b782 100644
--- a/tests/docker/dockerfiles/centos8.docker
+++ b/tests/docker/dockerfiles/centos8.docker
@@ -36,7 +36,6 @@ RUN dnf distro-sync -y && \
fuse3-devel \
gcc \
gcc-c++ \
- genisoimage \
gettext \
git \
glib2-devel \
@@ -82,6 +81,7 @@ RUN dnf distro-sync -y && \
lzo-devel \
make \
mesa-libgbm-devel \
+ mtools \
ncurses-devel \
nettle-devel \
ninja-build \
@@ -114,6 +114,7 @@ RUN dnf distro-sync -y && \
vte291-devel \
which \
xfsprogs-devel \
+ xorriso \
zlib-devel \
zlib-static \
zstd && \
diff --git a/tests/docker/dockerfiles/debian-amd64-cross.docker b/tests/docker/dockerfiles/debian-amd64-cross.docker
index 2e7eb445f1..40a2b6acc4 100644
--- a/tests/docker/dockerfiles/debian-amd64-cross.docker
+++ b/tests/docker/dockerfiles/debian-amd64-cross.docker
@@ -25,7 +25,6 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
findutils \
flex \
gcovr \
- genisoimage \
gettext \
git \
hostname \
@@ -37,6 +36,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
locales \
make \
meson \
+ mtools \
ncat \
ninja-build \
openssh-client \
@@ -57,6 +57,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
tar \
tesseract-ocr \
tesseract-ocr-eng \
+ xorriso \
zstd && \
eatmydata apt-get autoremove -y && \
eatmydata apt-get autoclean -y && \
diff --git a/tests/docker/dockerfiles/debian-amd64.docker b/tests/docker/dockerfiles/debian-amd64.docker
index 28e2fa81b1..e39871c7bb 100644
--- a/tests/docker/dockerfiles/debian-amd64.docker
+++ b/tests/docker/dockerfiles/debian-amd64.docker
@@ -28,7 +28,6 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
g++ \
gcc \
gcovr \
- genisoimage \
gettext \
git \
hostname \
@@ -103,6 +102,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
locales \
make \
meson \
+ mtools \
multipath-tools \
ncat \
nettle-dev \
@@ -127,6 +127,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
tesseract-ocr \
tesseract-ocr-eng \
xfslibs-dev \
+ xorriso \
zlib1g-dev \
zstd && \
eatmydata apt-get autoremove -y && \
diff --git a/tests/docker/dockerfiles/debian-arm64-cross.docker b/tests/docker/dockerfiles/debian-arm64-cross.docker
index f558770f84..c99300bbfa 100644
--- a/tests/docker/dockerfiles/debian-arm64-cross.docker
+++ b/tests/docker/dockerfiles/debian-arm64-cross.docker
@@ -25,7 +25,6 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
findutils \
flex \
gcovr \
- genisoimage \
gettext \
git \
hostname \
@@ -37,6 +36,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
locales \
make \
meson \
+ mtools \
ncat \
ninja-build \
openssh-client \
@@ -57,6 +57,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
tar \
tesseract-ocr \
tesseract-ocr-eng \
+ xorriso \
zstd && \
eatmydata apt-get autoremove -y && \
eatmydata apt-get autoclean -y && \
diff --git a/tests/docker/dockerfiles/debian-armel-cross.docker b/tests/docker/dockerfiles/debian-armel-cross.docker
index f3d7e07cce..5db5c78b31 100644
--- a/tests/docker/dockerfiles/debian-armel-cross.docker
+++ b/tests/docker/dockerfiles/debian-armel-cross.docker
@@ -25,7 +25,6 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
findutils \
flex \
gcovr \
- genisoimage \
gettext \
git \
hostname \
@@ -37,6 +36,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
locales \
make \
meson \
+ mtools \
ncat \
ninja-build \
openssh-client \
@@ -57,6 +57,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
tar \
tesseract-ocr \
tesseract-ocr-eng \
+ xorriso \
zstd && \
eatmydata apt-get autoremove -y && \
eatmydata apt-get autoclean -y && \
diff --git a/tests/docker/dockerfiles/debian-armhf-cross.docker b/tests/docker/dockerfiles/debian-armhf-cross.docker
index 531c556ad5..ae6600b25f 100644
--- a/tests/docker/dockerfiles/debian-armhf-cross.docker
+++ b/tests/docker/dockerfiles/debian-armhf-cross.docker
@@ -25,7 +25,6 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
findutils \
flex \
gcovr \
- genisoimage \
gettext \
git \
hostname \
@@ -37,6 +36,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
locales \
make \
meson \
+ mtools \
ncat \
ninja-build \
openssh-client \
@@ -57,6 +57,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
tar \
tesseract-ocr \
tesseract-ocr-eng \
+ xorriso \
zstd && \
eatmydata apt-get autoremove -y && \
eatmydata apt-get autoclean -y && \
diff --git a/tests/docker/dockerfiles/debian-mips64el-cross.docker b/tests/docker/dockerfiles/debian-mips64el-cross.docker
index 816dbd2911..daa2d48e36 100644
--- a/tests/docker/dockerfiles/debian-mips64el-cross.docker
+++ b/tests/docker/dockerfiles/debian-mips64el-cross.docker
@@ -25,7 +25,6 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
findutils \
flex \
gcovr \
- genisoimage \
gettext \
git \
hostname \
@@ -37,6 +36,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
locales \
make \
meson \
+ mtools \
ncat \
ninja-build \
openssh-client \
@@ -57,6 +57,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
tar \
tesseract-ocr \
tesseract-ocr-eng \
+ xorriso \
zstd && \
eatmydata apt-get autoremove -y && \
eatmydata apt-get autoclean -y && \
diff --git a/tests/docker/dockerfiles/debian-mipsel-cross.docker b/tests/docker/dockerfiles/debian-mipsel-cross.docker
index b115b29af3..5af04e2054 100644
--- a/tests/docker/dockerfiles/debian-mipsel-cross.docker
+++ b/tests/docker/dockerfiles/debian-mipsel-cross.docker
@@ -25,7 +25,6 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
findutils \
flex \
gcovr \
- genisoimage \
gettext \
git \
hostname \
@@ -37,6 +36,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
locales \
make \
meson \
+ mtools \
ncat \
ninja-build \
openssh-client \
@@ -57,6 +57,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
tar \
tesseract-ocr \
tesseract-ocr-eng \
+ xorriso \
zstd && \
eatmydata apt-get autoremove -y && \
eatmydata apt-get autoclean -y && \
diff --git a/tests/docker/dockerfiles/debian-ppc64el-cross.docker b/tests/docker/dockerfiles/debian-ppc64el-cross.docker
index 301bddb536..1eeba7fcab 100644
--- a/tests/docker/dockerfiles/debian-ppc64el-cross.docker
+++ b/tests/docker/dockerfiles/debian-ppc64el-cross.docker
@@ -25,7 +25,6 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
findutils \
flex \
gcovr \
- genisoimage \
gettext \
git \
hostname \
@@ -37,6 +36,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
locales \
make \
meson \
+ mtools \
ncat \
ninja-build \
openssh-client \
@@ -57,6 +57,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
tar \
tesseract-ocr \
tesseract-ocr-eng \
+ xorriso \
zstd && \
eatmydata apt-get autoremove -y && \
eatmydata apt-get autoclean -y && \
diff --git a/tests/docker/dockerfiles/debian-s390x-cross.docker b/tests/docker/dockerfiles/debian-s390x-cross.docker
index 5d27c91c17..52e89a6dab 100644
--- a/tests/docker/dockerfiles/debian-s390x-cross.docker
+++ b/tests/docker/dockerfiles/debian-s390x-cross.docker
@@ -25,7 +25,6 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
findutils \
flex \
gcovr \
- genisoimage \
gettext \
git \
hostname \
@@ -37,6 +36,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
locales \
make \
meson \
+ mtools \
ncat \
ninja-build \
openssh-client \
@@ -57,6 +57,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
tar \
tesseract-ocr \
tesseract-ocr-eng \
+ xorriso \
zstd && \
eatmydata apt-get autoremove -y && \
eatmydata apt-get autoclean -y && \
diff --git a/tests/docker/dockerfiles/fedora-win32-cross.docker b/tests/docker/dockerfiles/fedora-win32-cross.docker
index e7966ec7fd..dc72ae9cc9 100644
--- a/tests/docker/dockerfiles/fedora-win32-cross.docker
+++ b/tests/docker/dockerfiles/fedora-win32-cross.docker
@@ -30,7 +30,6 @@ exec "$@"\n' > /usr/bin/nosync && \
findutils \
flex \
gcovr \
- genisoimage \
git \
glib2-devel \
glibc-langpack-en \
@@ -38,6 +37,7 @@ exec "$@"\n' > /usr/bin/nosync && \
llvm \
make \
meson \
+ mtools \
ninja-build \
nmap-ncat \
openssh-clients \
@@ -59,6 +59,7 @@ exec "$@"\n' > /usr/bin/nosync && \
tesseract-langpack-eng \
util-linux \
which \
+ xorriso \
zstd && \
nosync dnf autoremove -y && \
nosync dnf clean all -y
diff --git a/tests/docker/dockerfiles/fedora-win64-cross.docker b/tests/docker/dockerfiles/fedora-win64-cross.docker
index 86c3a8f2ac..7eb4a5dba2 100644
--- a/tests/docker/dockerfiles/fedora-win64-cross.docker
+++ b/tests/docker/dockerfiles/fedora-win64-cross.docker
@@ -30,7 +30,6 @@ exec "$@"\n' > /usr/bin/nosync && \
findutils \
flex \
gcovr \
- genisoimage \
git \
glib2-devel \
glibc-langpack-en \
@@ -38,6 +37,7 @@ exec "$@"\n' > /usr/bin/nosync && \
llvm \
make \
meson \
+ mtools \
ninja-build \
nmap-ncat \
openssh-clients \
@@ -59,6 +59,7 @@ exec "$@"\n' > /usr/bin/nosync && \
tesseract-langpack-eng \
util-linux \
which \
+ xorriso \
zstd && \
nosync dnf autoremove -y && \
nosync dnf clean all -y
diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
index b698b7595d..3a69eefdda 100644
--- a/tests/docker/dockerfiles/fedora.docker
+++ b/tests/docker/dockerfiles/fedora.docker
@@ -43,7 +43,6 @@ exec "$@"\n' > /usr/bin/nosync && \
gcc \
gcc-c++ \
gcovr \
- genisoimage \
gettext \
git \
glib2-devel \
@@ -90,6 +89,7 @@ exec "$@"\n' > /usr/bin/nosync && \
make \
mesa-libgbm-devel \
meson \
+ mtools \
ncurses-devel \
nettle-devel \
ninja-build \
@@ -128,6 +128,7 @@ exec "$@"\n' > /usr/bin/nosync && \
which \
xen-devel \
xfsprogs-devel \
+ xorriso \
zlib-devel \
zlib-static \
zstd && \
diff --git a/tests/docker/dockerfiles/opensuse-leap.docker b/tests/docker/dockerfiles/opensuse-leap.docker
index afb9f5419f..185abe57d8 100644
--- a/tests/docker/dockerfiles/opensuse-leap.docker
+++ b/tests/docker/dockerfiles/opensuse-leap.docker
@@ -81,7 +81,7 @@ RUN zypper update -y && \
lttng-ust-devel \
lzo-devel \
make \
- mkisofs \
+ mtools \
ncat \
ncurses-devel \
ninja \
@@ -111,6 +111,7 @@ RUN zypper update -y && \
which \
xen-devel \
xfsprogs-devel \
+ xorriso \
zlib-devel \
zlib-devel-static \
zstd && \
diff --git a/tests/docker/dockerfiles/ubuntu2004.docker b/tests/docker/dockerfiles/ubuntu2004.docker
index aa2f5ca7b4..8f864d19e6 100644
--- a/tests/docker/dockerfiles/ubuntu2004.docker
+++ b/tests/docker/dockerfiles/ubuntu2004.docker
@@ -28,7 +28,6 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
g++ \
gcc \
gcovr \
- genisoimage \
gettext \
git \
hostname \
@@ -100,6 +99,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
llvm \
locales \
make \
+ mtools \
multipath-tools \
ncat \
nettle-dev \
@@ -126,6 +126,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
tesseract-ocr \
tesseract-ocr-eng \
xfslibs-dev \
+ xorriso \
zlib1g-dev \
zstd && \
eatmydata apt-get autoremove -y && \
diff --git a/tests/docker/dockerfiles/ubuntu2204.docker b/tests/docker/dockerfiles/ubuntu2204.docker
index 3f7d30e5d0..1d442cdfe6 100644
--- a/tests/docker/dockerfiles/ubuntu2204.docker
+++ b/tests/docker/dockerfiles/ubuntu2204.docker
@@ -28,7 +28,6 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
g++ \
gcc \
gcovr \
- genisoimage \
gettext \
git \
hostname \
@@ -103,6 +102,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
locales \
make \
meson \
+ mtools \
multipath-tools \
ncat \
nettle-dev \
@@ -127,6 +127,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
tesseract-ocr \
tesseract-ocr-eng \
xfslibs-dev \
+ xorriso \
zlib1g-dev \
zstd && \
eatmydata apt-get autoremove -y && \
diff --git a/tests/lcitool/projects/qemu.yml b/tests/lcitool/projects/qemu.yml
index af3700379a..566db8313b 100644
--- a/tests/lcitool/projects/qemu.yml
+++ b/tests/lcitool/projects/qemu.yml
@@ -26,7 +26,6 @@ packages:
- gcc
- gcovr
- gettext
- - genisoimage
- glib2
- glib2-native
- glib2-static
@@ -73,6 +72,7 @@ packages:
- llvm
- lttng-ust
- lzo
+ - mtools
- netcat
- nettle
- ninja
@@ -116,6 +116,7 @@ packages:
- which
- xen
- xfsprogs
+ - xorriso
- zstdtools
- zlib
- zlib-static
diff --git a/tests/qtest/cdrom-test.c b/tests/qtest/cdrom-test.c
index 26a2400181..73d45d7cef 100644
--- a/tests/qtest/cdrom-test.c
+++ b/tests/qtest/cdrom-test.c
@@ -17,7 +17,7 @@
static char isoimage[] = "cdrom-boot-iso-XXXXXX";
-static int exec_genisoimg(const char **args)
+static int exec_xorrisofs(const char **args)
{
gchar *out_err = NULL;
gint exit_status = -1;
@@ -43,7 +43,7 @@ static int prepare_image(const char *arch, char *isoimage)
char *codefile = NULL;
int ifh, ret = -1;
const char *args[] = {
- "genisoimage", "-quiet", "-l", "-no-emul-boot",
+ "xorrisofs", "-quiet", "-l", "-no-emul-boot",
"-b", NULL, "-o", isoimage, srcdir, NULL
};
@@ -75,9 +75,9 @@ static int prepare_image(const char *arch, char *isoimage)
}
args[5] = strchr(codefile, '/') + 1;
- ret = exec_genisoimg(args);
+ ret = exec_xorrisofs(args);
if (ret) {
- fprintf(stderr, "genisoimage failed: %i\n", ret);
+ fprintf(stderr, "xorrisofs failed: %i\n", ret);
}
unlink(codefile);
@@ -201,12 +201,12 @@ int main(int argc, char **argv)
{
int ret;
const char *arch = qtest_get_arch();
- const char *genisocheck[] = { "genisoimage", "-version", NULL };
+ const char *xorrisocheck[] = { "xorrisofs", "-version", NULL };
g_test_init(&argc, &argv, NULL);
- if (exec_genisoimg(genisocheck)) {
- /* genisoimage not available - so can't run tests */
+ if (exec_xorrisofs(xorrisocheck)) {
+ /* xorrisofs not available - so can't run tests */
return g_test_run();
}
--
2.31.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 0/2] tests/lcitool: Add mtools and xorriso and remove genisoimage as dependencies
2023-05-04 15:46 [PATCH v2 0/2] tests/lcitool: Add mtools and xorriso and remove genisoimage as dependencies Ani Sinha
2023-05-04 15:46 ` [PATCH v2 1/2] tests: libvirt-ci: Update to commit 'c8971e90ac' to pull in mformat and xorriso Ani Sinha
2023-05-04 15:46 ` [PATCH v2 2/2] tests/lcitool: Add mtools and xorriso and remove genisoimage as dependencies Ani Sinha
@ 2023-05-04 16:27 ` Ani Sinha
2023-05-09 16:16 ` Michael S. Tsirkin
3 siblings, 0 replies; 9+ messages in thread
From: Ani Sinha @ 2023-05-04 16:27 UTC (permalink / raw)
To: qemu-devel
Cc: Michael S. Tsirkin, berrange, alex.bennee,
Philippe Mathieu-Daudé, wainersm, bleal, thuth
> On 04-May-2023, at 9:16 PM, Ani Sinha <anisinha@redhat.com> wrote:
>
> mformat and xorriso tools are needed by biosbits avocado tests. This patchset
> adds those two tools in the docker container images.
> xorriso package conflicts with genisoimage package on some distributions.
> Therefore, it is not possible to have both the packages at the same time
> in the container image uniformly for all distribution flavors. Further,
> on some distributions like RHEL, both xorriso and genisoimage
> packages provide /usr/bin/genisoimage and on some other distributions like
> Fedora, only genisoimage package provides the same utility.
> Therefore, this change removes the dependency on geninsoimage for building
> container images altogether keeping only xorriso package. At the same time,
> cdrom-test.c is updated to use and check for existence of only xorrisofs.
>
> Patch 1 pulls in the latest changes in lcitool in order to add mappings
> for these packages in various distros.
> Patch 2 updates all Dockerfiles in QEMU repository to add these two
> tools. It also removed genisoimage package and updated cdrom-test to not
> use genisoimage but xorrisofs.
>
> CC: mst@redhat.com
> CC: berrange@redhat.com
> CC: alex.bennee@linaro.org
> CC: philmd@linaro.org
> CC: wainersm@redhat.com
> CC: bleal@redhat.com
> CC: thuth@redhat.com
> TO: qemu-devel@nongnu.org
>
> Changelog:
> v2: remove genisoimage package and update Dockerfile. Also update cdrom-test.c
> so that it uses xorrisofs and not genisoimage. I have tested patch #2 on both
> Fedora 37 and RHEL 9.1. cdrom-test passed on both.
Also running this pipeline right now to verify:
https://gitlab.com/anisinha/qemu/-/pipelines/857490765
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] tests: libvirt-ci: Update to commit 'c8971e90ac' to pull in mformat and xorriso
2023-05-04 15:46 ` [PATCH v2 1/2] tests: libvirt-ci: Update to commit 'c8971e90ac' to pull in mformat and xorriso Ani Sinha
@ 2023-05-04 17:17 ` Thomas Huth
0 siblings, 0 replies; 9+ messages in thread
From: Thomas Huth @ 2023-05-04 17:17 UTC (permalink / raw)
To: Ani Sinha, qemu-devel, Alex Bennée,
Philippe Mathieu-Daudé, Wainer dos Santos Moschetta,
Beraldo Leal
Cc: mst, berrange
On 04/05/2023 17.46, Ani Sinha wrote:
> Pull in the following changes from lcitool:
>
> * tests/lcitool/libvirt-ci 85487e1...c8971e9 (18):
> > mappings: add new package mappings for mformat and xorriso
> > docs: testing: Update contents with tox
> > .gitlab-ci.yml: Always test against installed lcitool
> > gitlab-ci.yml: Start using tox for testing
> > tox: Allow running with custom pytest options with {posargs}
> > gitignore: Add the default .tox directory
> > dev-requirements: Reference VM requirements
> > requirements: Add tox to dev-requirements.txt and drop pytest and flake
> > test-requirements: Rename to dev-requirements.txt
> > Add tox.ini configuration file
> > tests: commands: Consolidate the installed package/run from git tests
> > Add a pytest.ini
> > facts: targets: Drop Fedora 36 target
> > gitlab-ci.yml: Add Fedora 38 target
> > facts: targets: Add Fedora 38
> > facts: mappings: Drop 'zstd' mapping
> > facts: projects: nbdkit: Replace zstd mapping with libzstd
> > docs: mappings: Add a section on the preferred mapping naming scheme
>
> CC: mst@redhat.com
> CC: berrange@redhat.com
> Signed-off-by: Ani Sinha <anisinha@redhat.com>
> ---
> tests/lcitool/libvirt-ci | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/lcitool/libvirt-ci b/tests/lcitool/libvirt-ci
> index 85487e1404..c8971e90ac 160000
> --- a/tests/lcitool/libvirt-ci
> +++ b/tests/lcitool/libvirt-ci
> @@ -1 +1 @@
> -Subproject commit 85487e140415b2ac54b01a9a6b600fd7c21edc2f
> +Subproject commit c8971e90ac169ee2b539c747f74d96c876debdf9
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] tests/lcitool: Add mtools and xorriso and remove genisoimage as dependencies
2023-05-04 15:46 ` [PATCH v2 2/2] tests/lcitool: Add mtools and xorriso and remove genisoimage as dependencies Ani Sinha
@ 2023-05-04 17:23 ` Thomas Huth
0 siblings, 0 replies; 9+ messages in thread
From: Thomas Huth @ 2023-05-04 17:23 UTC (permalink / raw)
To: Ani Sinha, qemu-devel, Ed Maste, Li-Wen Hsu, Alex Bennée,
Philippe Mathieu-Daudé, Wainer dos Santos Moschetta,
Beraldo Leal, John Snow, Laurent Vivier, Paolo Bonzini
Cc: mst, berrange, qemu-block
On 04/05/2023 17.46, Ani Sinha wrote:
> Bios bits avocado tests need mformat (provided by the mtools package) and
> xorriso tools in order to run within gitlab CI containers. Add those
> dependencies within the Dockerfiles so that containers can be built with
> those tools present and bios bits avocado tests can be run there.
>
> xorriso package conflicts with genisoimage package on some distributions.
> Therefore, it is not possible to have both the packages at the same time
> in the container image uniformly for all distribution flavors. Further,
> on some distributions like RHEL, both xorriso and genisoimage
> packages provide /usr/bin/genisoimage and on some other distributions like
> Fedora, only genisoimage package provides the same utility.
> Therefore, this change removes the dependency on geninsoimage for building
> container images altogether keeping only xorriso package. At the same time,
> cdrom-test.c is updated to use and check for existence of only xorrisofs.
>
> CC: mst@redhat.com
> CC: berrange@redhat.com
> Signed-off-by: Ani Sinha <anisinha@redhat.com>
> ---
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 0/2] tests/lcitool: Add mtools and xorriso and remove genisoimage as dependencies
2023-05-04 15:46 [PATCH v2 0/2] tests/lcitool: Add mtools and xorriso and remove genisoimage as dependencies Ani Sinha
` (2 preceding siblings ...)
2023-05-04 16:27 ` [PATCH v2 0/2] " Ani Sinha
@ 2023-05-09 16:16 ` Michael S. Tsirkin
2023-05-10 6:39 ` Thomas Huth
3 siblings, 1 reply; 9+ messages in thread
From: Michael S. Tsirkin @ 2023-05-09 16:16 UTC (permalink / raw)
To: Ani Sinha
Cc: qemu-devel, berrange, alex.bennee, philmd, wainersm, bleal, thuth
On Thu, May 04, 2023 at 09:16:09PM +0530, Ani Sinha wrote:
> mformat and xorriso tools are needed by biosbits avocado tests. This patchset
> adds those two tools in the docker container images.
> xorriso package conflicts with genisoimage package on some distributions.
> Therefore, it is not possible to have both the packages at the same time
> in the container image uniformly for all distribution flavors. Further,
> on some distributions like RHEL, both xorriso and genisoimage
> packages provide /usr/bin/genisoimage and on some other distributions like
> Fedora, only genisoimage package provides the same utility.
> Therefore, this change removes the dependency on geninsoimage for building
> container images altogether keeping only xorriso package. At the same time,
> cdrom-test.c is updated to use and check for existence of only xorrisofs.
>
> Patch 1 pulls in the latest changes in lcitool in order to add mappings
> for these packages in various distros.
> Patch 2 updates all Dockerfiles in QEMU repository to add these two
> tools. It also removed genisoimage package and updated cdrom-test to not
> use genisoimage but xorrisofs.
>
> CC: mst@redhat.com
> CC: berrange@redhat.com
> CC: alex.bennee@linaro.org
> CC: philmd@linaro.org
> CC: wainersm@redhat.com
> CC: bleal@redhat.com
> CC: thuth@redhat.com
> TO: qemu-devel@nongnu.org
>
> Changelog:
> v2: remove genisoimage package and update Dockerfile. Also update cdrom-test.c
> so that it uses xorrisofs and not genisoimage. I have tested patch #2 on both
> Fedora 37 and RHEL 9.1. cdrom-test passed on both.
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
who's merging this?
> Ani Sinha (2):
> tests: libvirt-ci: Update to commit 'c8971e90ac' to pull in mformat
> and xorriso
> tests/lcitool: Add mtools and xorriso and remove genisoimage as
> dependencies
>
> .gitlab-ci.d/cirrus/freebsd-13.vars | 2 +-
> .gitlab-ci.d/cirrus/macos-12.vars | 2 +-
> tests/docker/dockerfiles/alpine.docker | 3 ++-
> tests/docker/dockerfiles/centos8.docker | 3 ++-
> tests/docker/dockerfiles/debian-amd64-cross.docker | 3 ++-
> tests/docker/dockerfiles/debian-amd64.docker | 3 ++-
> tests/docker/dockerfiles/debian-arm64-cross.docker | 3 ++-
> tests/docker/dockerfiles/debian-armel-cross.docker | 3 ++-
> tests/docker/dockerfiles/debian-armhf-cross.docker | 3 ++-
> .../dockerfiles/debian-mips64el-cross.docker | 3 ++-
> .../docker/dockerfiles/debian-mipsel-cross.docker | 3 ++-
> .../docker/dockerfiles/debian-ppc64el-cross.docker | 3 ++-
> tests/docker/dockerfiles/debian-s390x-cross.docker | 3 ++-
> tests/docker/dockerfiles/fedora-win32-cross.docker | 3 ++-
> tests/docker/dockerfiles/fedora-win64-cross.docker | 3 ++-
> tests/docker/dockerfiles/fedora.docker | 3 ++-
> tests/docker/dockerfiles/opensuse-leap.docker | 3 ++-
> tests/docker/dockerfiles/ubuntu2004.docker | 3 ++-
> tests/docker/dockerfiles/ubuntu2204.docker | 3 ++-
> tests/lcitool/libvirt-ci | 2 +-
> tests/lcitool/projects/qemu.yml | 3 ++-
> tests/qtest/cdrom-test.c | 14 +++++++-------
> 22 files changed, 46 insertions(+), 28 deletions(-)
>
> --
> 2.31.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 0/2] tests/lcitool: Add mtools and xorriso and remove genisoimage as dependencies
2023-05-09 16:16 ` Michael S. Tsirkin
@ 2023-05-10 6:39 ` Thomas Huth
2023-05-10 6:41 ` Michael S. Tsirkin
0 siblings, 1 reply; 9+ messages in thread
From: Thomas Huth @ 2023-05-10 6:39 UTC (permalink / raw)
To: Michael S. Tsirkin, Ani Sinha
Cc: qemu-devel, berrange, alex.bennee, philmd, wainersm, bleal
On 09/05/2023 18.16, Michael S. Tsirkin wrote:
> On Thu, May 04, 2023 at 09:16:09PM +0530, Ani Sinha wrote:
>> mformat and xorriso tools are needed by biosbits avocado tests. This patchset
>> adds those two tools in the docker container images.
>> xorriso package conflicts with genisoimage package on some distributions.
>> Therefore, it is not possible to have both the packages at the same time
>> in the container image uniformly for all distribution flavors. Further,
>> on some distributions like RHEL, both xorriso and genisoimage
>> packages provide /usr/bin/genisoimage and on some other distributions like
>> Fedora, only genisoimage package provides the same utility.
>> Therefore, this change removes the dependency on geninsoimage for building
>> container images altogether keeping only xorriso package. At the same time,
>> cdrom-test.c is updated to use and check for existence of only xorrisofs.
>>
>> Patch 1 pulls in the latest changes in lcitool in order to add mappings
>> for these packages in various distros.
>> Patch 2 updates all Dockerfiles in QEMU repository to add these two
>> tools. It also removed genisoimage package and updated cdrom-test to not
>> use genisoimage but xorrisofs.
>>
>> CC: mst@redhat.com
>> CC: berrange@redhat.com
>> CC: alex.bennee@linaro.org
>> CC: philmd@linaro.org
>> CC: wainersm@redhat.com
>> CC: bleal@redhat.com
>> CC: thuth@redhat.com
>> TO: qemu-devel@nongnu.org
>>
>> Changelog:
>> v2: remove genisoimage package and update Dockerfile. Also update cdrom-test.c
>> so that it uses xorrisofs and not genisoimage. I have tested patch #2 on both
>> Fedora 37 and RHEL 9.1. cdrom-test passed on both.
>
>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
>
> who's merging this?
I guess it's either you, Alex or me ... I'll put it into my queue, but if
you plan a pull request soon, feel free to take it first.
Thomas
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 0/2] tests/lcitool: Add mtools and xorriso and remove genisoimage as dependencies
2023-05-10 6:39 ` Thomas Huth
@ 2023-05-10 6:41 ` Michael S. Tsirkin
0 siblings, 0 replies; 9+ messages in thread
From: Michael S. Tsirkin @ 2023-05-10 6:41 UTC (permalink / raw)
To: Thomas Huth
Cc: Ani Sinha, qemu-devel, berrange, alex.bennee, philmd, wainersm,
bleal
On Wed, May 10, 2023 at 08:39:54AM +0200, Thomas Huth wrote:
> On 09/05/2023 18.16, Michael S. Tsirkin wrote:
> > On Thu, May 04, 2023 at 09:16:09PM +0530, Ani Sinha wrote:
> > > mformat and xorriso tools are needed by biosbits avocado tests. This patchset
> > > adds those two tools in the docker container images.
> > > xorriso package conflicts with genisoimage package on some distributions.
> > > Therefore, it is not possible to have both the packages at the same time
> > > in the container image uniformly for all distribution flavors. Further,
> > > on some distributions like RHEL, both xorriso and genisoimage
> > > packages provide /usr/bin/genisoimage and on some other distributions like
> > > Fedora, only genisoimage package provides the same utility.
> > > Therefore, this change removes the dependency on geninsoimage for building
> > > container images altogether keeping only xorriso package. At the same time,
> > > cdrom-test.c is updated to use and check for existence of only xorrisofs.
> > >
> > > Patch 1 pulls in the latest changes in lcitool in order to add mappings
> > > for these packages in various distros.
> > > Patch 2 updates all Dockerfiles in QEMU repository to add these two
> > > tools. It also removed genisoimage package and updated cdrom-test to not
> > > use genisoimage but xorrisofs.
> > >
> > > CC: mst@redhat.com
> > > CC: berrange@redhat.com
> > > CC: alex.bennee@linaro.org
> > > CC: philmd@linaro.org
> > > CC: wainersm@redhat.com
> > > CC: bleal@redhat.com
> > > CC: thuth@redhat.com
> > > TO: qemu-devel@nongnu.org
> > >
> > > Changelog:
> > > v2: remove genisoimage package and update Dockerfile. Also update cdrom-test.c
> > > so that it uses xorrisofs and not genisoimage. I have tested patch #2 on both
> > > Fedora 37 and RHEL 9.1. cdrom-test passed on both.
> >
> >
> > Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> >
> > who's merging this?
>
> I guess it's either you, Alex or me ... I'll put it into my queue, but if
> you plan a pull request soon, feel free to take it first.
>
> Thomas
yes there's a pull by end of week. sure I'll take this.
--
MST
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-05-10 6:42 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-04 15:46 [PATCH v2 0/2] tests/lcitool: Add mtools and xorriso and remove genisoimage as dependencies Ani Sinha
2023-05-04 15:46 ` [PATCH v2 1/2] tests: libvirt-ci: Update to commit 'c8971e90ac' to pull in mformat and xorriso Ani Sinha
2023-05-04 17:17 ` Thomas Huth
2023-05-04 15:46 ` [PATCH v2 2/2] tests/lcitool: Add mtools and xorriso and remove genisoimage as dependencies Ani Sinha
2023-05-04 17:23 ` Thomas Huth
2023-05-04 16:27 ` [PATCH v2 0/2] " Ani Sinha
2023-05-09 16:16 ` Michael S. Tsirkin
2023-05-10 6:39 ` Thomas Huth
2023-05-10 6:41 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).