From: Max Reitz <mreitz@redhat.com>
To: Liam Merwick <Liam.Merwick@oracle.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, kwolf@redhat.com, jsnow@redhat.com,
berrange@redhat.com
Subject: Re: [Qemu-devel] [PATCH v5 2/5] block: Null pointer dereference in blk_root_get_parent_desc()
Date: Sun, 11 Nov 2018 20:12:23 +0100 [thread overview]
Message-ID: <f5a910bd-2f23-5778-9845-865cbb8b8191@redhat.com> (raw)
In-Reply-To: <1541453919-25973-3-git-send-email-Liam.Merwick@oracle.com>
[-- Attachment #1: Type: text/plain, Size: 673 bytes --]
On 05.11.18 22:38, Liam Merwick wrote:
> The dev_id returned by the call to blk_get_attached_dev_id() in
> blk_root_get_parent_desc() can be NULL (an internal call to
> object_get_canonical_path may have returned NULL).
>
> Instead of just checking this case before before dereferencing,
> adjust blk_get_attached_dev_id() to return the empty string if no
> object path can be found (similar to the case when blk->dev is NULL
> and an empty string is returned).
>
> Signed-off-by: Liam Merwick <Liam.Merwick@oracle.com>
> ---
> block/block-backend.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-11-11 19:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 21:38 [Qemu-devel] [PATCH v5 0/5] off-by-one and NULL pointer accesses detected by static analysis Liam Merwick
2018-11-05 21:38 ` [Qemu-devel] [PATCH v5 1/5] job: Fix off-by-one assert checks for JobSTT and JobVerbTable Liam Merwick
2018-11-05 21:38 ` [Qemu-devel] [PATCH v5 2/5] block: Null pointer dereference in blk_root_get_parent_desc() Liam Merwick
2018-11-11 19:12 ` Max Reitz [this message]
2018-11-05 21:38 ` [Qemu-devel] [PATCH v5 3/5] qemu-img: assert block_job_get() does not return NULL in img_commit() Liam Merwick
2018-11-05 21:38 ` [Qemu-devel] [PATCH v5 4/5] block: Fix potential Null pointer dereferences in vvfat.c Liam Merwick
2018-11-11 19:22 ` Max Reitz
2018-11-05 21:38 ` [Qemu-devel] [PATCH v5 5/5] qcow2: Read outside array bounds in qcow2_pre_write_overlap_check() Liam Merwick
2018-11-11 19:31 ` [Qemu-devel] [PATCH v5 0/5] off-by-one and NULL pointer accesses detected by static analysis Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5a910bd-2f23-5778-9845-865cbb8b8191@redhat.com \
--to=mreitz@redhat.com \
--cc=Liam.Merwick@oracle.com \
--cc=berrange@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).