From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18BFEC77B73 for ; Mon, 22 May 2023 06:07:17 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q0yh7-0000UH-NI; Mon, 22 May 2023 02:06:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q0yh2-0000Pr-Uv for qemu-devel@nongnu.org; Mon, 22 May 2023 02:06:55 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q0yh0-0002EP-66 for qemu-devel@nongnu.org; Mon, 22 May 2023 02:06:52 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-3f41d087a84so21013125e9.1 for ; Sun, 21 May 2023 23:06:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684735608; x=1687327608; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=42PH/00QoWmPwyG5RAq9Du9zwqNWKsNLPesCLbcp4J0=; b=f900Q2VuftbThemhFu2SJgpGaRXrk29p3nbGjjoxRtPJc7gkBnCt8X4DFRy4zf12w0 AeOEm9A78B9jIGgZdtCFPdWQie0jojHPZNjDudu6Er/d4YMioQ88SpwXV+wd0bj92Uj3 kDJm8KOfId4K19A3QDD0cgJCi5A2q57SA0IA4+lgxLNPojX7XhfNl19v5MWrwgZtWRLT U03lXfGdWVINB0tN+5aNHBIEvSqfzybguZwguI+vmwjh+W61NHVl55D5uN7d16gJiJT/ omqP2gwZIYPqXePD94/0WAdFlry3dHzMnCudz8aUngWczXH+2WFZ06Cz063i9UMKg+oZ scmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684735608; x=1687327608; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=42PH/00QoWmPwyG5RAq9Du9zwqNWKsNLPesCLbcp4J0=; b=OKMZUQrBJN7wqIpzBLZELXc5yDGLzyWxjHkqMyuXKLOYJTEf+WJM6HhO/pPX0a+AfM SYJh7YegNUxOjrQdr/3xXxemYNM9sXkYpLDRI+POXcJ4uSm5eV6tWmNiptiY7h/D9LhN zvmRiGRVflnamZbhVPYVunA3Z5a/GEJz8/6P4eolF9qXICuO0iArtrUfAeVeZAbEQB87 Hse5nZKrVpdPVfubvc6TtEaEp0W9xLbUgo5Fu4NPwxabwBXxsd3833Wn6TgBJYlJeaE0 mXNnRX+CJF9putmhFIvKgpkwk5SE56pjMvZ8eEsCwGa0vlhiY3SI7ts2WImVHhmrIxId uPUA== X-Gm-Message-State: AC+VfDyBwQu2nFX+bujYeOOWeTCqHgtLzulq4VAk5K4CPrOlDAYxPf/s yAiAM588Ow4PBnCYdAq2AW1diQ== X-Google-Smtp-Source: ACHHUZ7RtomUNjN4IxHCiR3WVGfn2PmHnVOl/V8h+pRFjo8RgIKioENpg/4+S4s4Mtvu6+UZYz+R7A== X-Received: by 2002:a05:600c:1e01:b0:3f5:6e6:4285 with SMTP id ay1-20020a05600c1e0100b003f506e64285mr6600095wmb.11.1684735608023; Sun, 21 May 2023 23:06:48 -0700 (PDT) Received: from [192.168.69.115] ([176.176.153.164]) by smtp.gmail.com with ESMTPSA id n10-20020adfe78a000000b0030796e103a1sm6586280wrm.5.2023.05.21.23.06.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 May 2023 23:06:47 -0700 (PDT) Message-ID: Date: Mon, 22 May 2023 08:06:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 6/6] hw/char/parallel: Replace string literals by TYPE_ISA_PARALLEL macro Content-Language: en-US To: Bernhard Beschow , qemu-devel@nongnu.org Cc: Michael Tokarev , Laurent Vivier , Marcel Apfelbaum , qemu-trivial@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?Q?Herv=c3=a9_Poussineau?= , "Michael S. Tsirkin" , Paolo Bonzini , Eduardo Habkost , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Richard Henderson , qemu-ppc@nongnu.org, Peter Maydell References: <20230521123049.312349-1-shentey@gmail.com> <20230521123049.312349-7-shentey@gmail.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230521123049.312349-7-shentey@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.098, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 21/5/23 14:30, Bernhard Beschow wrote: > Rather than using a string literal which is prone to typos let's use a macro > instead which is caught by the compiler if mistyped. > > Signed-off-by: Bernhard Beschow > Acked-by: Michael S. Tsirkin > --- > hw/char/parallel-isa.c | 3 ++- > hw/isa/isa-superio.c | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé