From: Thomas Huth <thuth@redhat.com>
To: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org,
Lars Biermanski <lars.biermanski@efs-auto.de>,
Georg Hofstetter <georg.hofstetter@efs-auto.de>,
David Brenken <david.brenken@efs-auto.de>,
Robert Rasche <robert.rasche@efs-auto.de>,
Andreas Konopik <andreas.konopik@efs-auto.de>
Subject: Re: [PULL 1/1] tricore: added triboard with tc27x_soc
Date: Wed, 2 Sep 2020 16:46:39 +0200 [thread overview]
Message-ID: <f5bbb1bb-0ab9-7bcd-3cca-3891ecaef812@redhat.com> (raw)
In-Reply-To: <20200901095924.21738-2-kbastian@mail.uni-paderborn.de>
Hi,
On 01/09/2020 11.59, Bastian Koppelmann wrote:
> From: Andreas Konopik <andreas.konopik@efs-auto.de>
>
> Signed-off-by: Andreas Konopik <andreas.konopik@efs-auto.de>
> Signed-off-by: David Brenken <david.brenken@efs-auto.de>
> Signed-off-by: Georg Hofstetter <georg.hofstetter@efs-auto.de>
> Signed-off-by: Robert Rasche <robert.rasche@efs-auto.de>
> Signed-off-by: Lars Biermanski <lars.biermanski@efs-auto.de>
> Message-Id: <20200622131934.10328-2-david.brenken@efs-auto.org>
> Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
> [BK: Fixed build system to use meson]
> ---
> hw/tricore/Kconfig | 8 ++
> hw/tricore/meson.build | 2 +
> hw/tricore/tc27x_soc.c | 246 +++++++++++++++++++++++++++++++++
> hw/tricore/triboard.c | 102 ++++++++++++++
> include/hw/tricore/tc27x_soc.h | 139 +++++++++++++++++++
> include/hw/tricore/triboard.h | 53 +++++++
> 6 files changed, 550 insertions(+)
> create mode 100644 hw/tricore/tc27x_soc.c
> create mode 100644 hw/tricore/triboard.c
> create mode 100644 include/hw/tricore/tc27x_soc.h
> create mode 100644 include/hw/tricore/triboard.h
>
> diff --git a/hw/tricore/Kconfig b/hw/tricore/Kconfig
> index 9313409309..44d3e906a1 100644
> --- a/hw/tricore/Kconfig
> +++ b/hw/tricore/Kconfig
> @@ -1,2 +1,10 @@
> config TRICORE
> bool
> + select TRIBOARD
> +
> +config TRIBOARD
> + bool
> + select TC27X_SOC
I think it would be more common to do it the other way round: TRIBOARD
should select TRICORE, and then use "CONFIG_TRIBOARD=y" in the
default-configs/tricore-softmmu.mak file instead.
(We usually set CONFIG_SOMEBOARD=y in the default-configs/*.mak files,
and the boards then select the required components)
> +config TC27X_SOC
> + bool
> diff --git a/hw/tricore/meson.build b/hw/tricore/meson.build
> index 579aa13c78..305f7f27db 100644
> --- a/hw/tricore/meson.build
> +++ b/hw/tricore/meson.build
> @@ -1,4 +1,6 @@
> tricore_ss = ss.source_set()
> tricore_ss.add(when: 'CONFIG_TRICORE', if_true: files('tricore_testboard.c'))
> +tricore_ss.add(when: 'CONFIG_TRICORE', if_true: files('tc27x_soc.c'))
> +tricore_ss.add(when: 'CONFIG_TRICORE', if_true: files('triboard.c'))
You should maybe rather use CONFIG_TRIBOARD and CONFIG_TC27X_SOC here
since you've also introduced these symbols in the Kconfig file.
Thomas
next prev parent reply other threads:[~2020-09-02 14:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 9:59 [PULL 0/1] tricore queue Bastian Koppelmann
2020-09-01 9:59 ` [PULL 1/1] tricore: added triboard with tc27x_soc Bastian Koppelmann
2020-09-02 14:46 ` Thomas Huth [this message]
2020-09-01 14:18 ` [PULL 0/1] tricore queue Peter Maydell
2020-09-02 12:55 ` Bastian Koppelmann
2020-10-28 11:19 ` Konopik, Andreas (EFS-GH2)
-- strict thread matches above, loose matches on Subject: below --
2021-02-10 9:29 Bastian Koppelmann
2021-02-10 9:29 ` [PULL 1/1] tricore: added triboard with tc27x_soc Bastian Koppelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5bbb1bb-0ab9-7bcd-3cca-3891ecaef812@redhat.com \
--to=thuth@redhat.com \
--cc=andreas.konopik@efs-auto.de \
--cc=david.brenken@efs-auto.de \
--cc=georg.hofstetter@efs-auto.de \
--cc=kbastian@mail.uni-paderborn.de \
--cc=lars.biermanski@efs-auto.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=robert.rasche@efs-auto.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).