qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH] hw/audio/virtio-snd: Remove unused assignment
Date: Wed, 10 Apr 2024 11:07:07 +0200	[thread overview]
Message-ID: <f5d59a3f-a808-43b7-a270-5b1263fa2482@linaro.org> (raw)
In-Reply-To: <20240410053712.34747-1-philmd@linaro.org>

On 10/4/24 07:37, Philippe Mathieu-Daudé wrote:
> Coverity reported:
> 
>    >>>     CID 1542933:  Code maintainability issues  (UNUSED_VALUE)
>    >>>     CID 1542934:  Code maintainability issues  (UNUSED_VALUE)
>    >>>     Assigning value "NULL" to "stream" here, but that stored
>            value is overwritten before it can be used.
> 
> Simply remove the unused assignments.
> 
> Resolves: Coverity CID 1542933
> Resolves: Coverity CID 1542934
> Fixes: 731655f87f ("virtio-snd: rewrite invalid tx/rx message handling")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   hw/audio/virtio-snd.c | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)

Per IRC:
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>

Thanks, queued.


      reply	other threads:[~2024-04-10  9:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-10  5:37 [PATCH] hw/audio/virtio-snd: Remove unused assignment Philippe Mathieu-Daudé
2024-04-10  9:07 ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f5d59a3f-a808-43b7-a270-5b1263fa2482@linaro.org \
    --to=philmd@linaro.org \
    --cc=kraxel@redhat.com \
    --cc=manos.pitsidianakis@linaro.org \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).