* [PATCH] hw/audio/virtio-snd: Remove unused assignment
@ 2024-04-10 5:37 Philippe Mathieu-Daudé
2024-04-10 9:07 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-04-10 5:37 UTC (permalink / raw)
To: qemu-devel
Cc: Michael S. Tsirkin, Manos Pitsidianakis, Gerd Hoffmann,
Philippe Mathieu-Daudé
Coverity reported:
>>> CID 1542933: Code maintainability issues (UNUSED_VALUE)
>>> CID 1542934: Code maintainability issues (UNUSED_VALUE)
>>> Assigning value "NULL" to "stream" here, but that stored
value is overwritten before it can be used.
Simply remove the unused assignments.
Resolves: Coverity CID 1542933
Resolves: Coverity CID 1542934
Fixes: 731655f87f ("virtio-snd: rewrite invalid tx/rx message handling")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/audio/virtio-snd.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c
index 90d9a2796e..c80b58bf5d 100644
--- a/hw/audio/virtio-snd.c
+++ b/hw/audio/virtio-snd.c
@@ -885,7 +885,9 @@ static void virtio_snd_handle_tx_xfer(VirtIODevice *vdev, VirtQueue *vq)
}
trace_virtio_snd_handle_tx_xfer();
- for (VirtIOSoundPCMStream *stream = NULL;; stream = NULL) {
+ for (;;) {
+ VirtIOSoundPCMStream *stream;
+
elem = virtqueue_pop(vq, sizeof(VirtQueueElement));
if (!elem) {
break;
@@ -964,7 +966,9 @@ static void virtio_snd_handle_rx_xfer(VirtIODevice *vdev, VirtQueue *vq)
}
trace_virtio_snd_handle_rx_xfer();
- for (VirtIOSoundPCMStream *stream = NULL;; stream = NULL) {
+ for (;;) {
+ VirtIOSoundPCMStream *stream;
+
elem = virtqueue_pop(vq, sizeof(VirtQueueElement));
if (!elem) {
break;
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] hw/audio/virtio-snd: Remove unused assignment
2024-04-10 5:37 [PATCH] hw/audio/virtio-snd: Remove unused assignment Philippe Mathieu-Daudé
@ 2024-04-10 9:07 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-04-10 9:07 UTC (permalink / raw)
To: qemu-devel; +Cc: Michael S. Tsirkin, Manos Pitsidianakis, Gerd Hoffmann
On 10/4/24 07:37, Philippe Mathieu-Daudé wrote:
> Coverity reported:
>
> >>> CID 1542933: Code maintainability issues (UNUSED_VALUE)
> >>> CID 1542934: Code maintainability issues (UNUSED_VALUE)
> >>> Assigning value "NULL" to "stream" here, but that stored
> value is overwritten before it can be used.
>
> Simply remove the unused assignments.
>
> Resolves: Coverity CID 1542933
> Resolves: Coverity CID 1542934
> Fixes: 731655f87f ("virtio-snd: rewrite invalid tx/rx message handling")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/audio/virtio-snd.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Per IRC:
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Thanks, queued.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-10 9:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-10 5:37 [PATCH] hw/audio/virtio-snd: Remove unused assignment Philippe Mathieu-Daudé
2024-04-10 9:07 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).