From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
qemu-s390x@nongnu.org, Cornelia Huck <cohuck@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel@nongnu.org
Subject: Re: [PATCH 1/3] pc-bios/s390-ccw: Fix inline assembly for older versions of Clang
Date: Wed, 12 May 2021 21:52:36 +0200 [thread overview]
Message-ID: <f5da1494-ec3a-c68d-cf56-f0ee752e5a46@redhat.com> (raw)
In-Reply-To: <20210512171550.476130-2-thuth@redhat.com>
On 5/12/21 7:15 PM, Thomas Huth wrote:
> Clang versions before v11.0 insist on having the %rX or %cX register
> names instead of just a number. Since our Travis-CI is currently
> still using Clang v6.0, we have to fix this to avoid failing jobs.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> pc-bios/s390-ccw/helper.h | 2 +-
> pc-bios/s390-ccw/jump2ipl.c | 4 ++--
> pc-bios/s390-ccw/menu.c | 8 ++++----
> pc-bios/s390-ccw/virtio.c | 2 +-
> 4 files changed, 8 insertions(+), 8 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2021-05-12 20:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 17:15 [PATCH 0/3] Fix Travis-CI / compiling with older versions of Clang Thomas Huth
2021-05-12 17:15 ` [PATCH 1/3] pc-bios/s390-ccw: Fix inline assembly for " Thomas Huth
2021-05-12 19:52 ` Philippe Mathieu-Daudé [this message]
2021-05-17 16:14 ` Cornelia Huck
2021-05-17 16:49 ` Philippe Mathieu-Daudé
2021-05-12 17:15 ` [PATCH 2/3] pc-bios/s390-ccw/Makefile: Check more compiler flags for Clang Thomas Huth
2021-05-12 19:58 ` Philippe Mathieu-Daudé
2021-05-12 17:15 ` [PATCH 3/3] pc-bios/s390-ccw: Add a proper prototype for main() Thomas Huth
2021-05-12 19:54 ` Philippe Mathieu-Daudé
2021-05-14 10:09 ` Thomas Huth
2021-05-17 16:48 ` Philippe Mathieu-Daudé
2021-05-17 16:22 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5da1494-ec3a-c68d-cf56-f0ee752e5a46@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).