From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58504) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4qdg-0004UI-IJ for qemu-devel@nongnu.org; Wed, 18 Oct 2017 11:52:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4qdb-0001vb-1x for qemu-devel@nongnu.org; Wed, 18 Oct 2017 11:52:12 -0400 References: <503559b438cd67b865d32d7d0577afc7ee15f32c.1508257445.git.jcody@redhat.com> <2de32e52-2c2a-5738-4624-d84bf7379c5f@redhat.com> <20171018150352.GE17962@localhost.localdomain> <20171018153416.GF17962@localhost.localdomain> <07a69c86-aae3-9174-b646-dee04bf191de@redhat.com> <20171018155038.GG17962@localhost.localdomain> From: Paolo Bonzini Message-ID: Date: Wed, 18 Oct 2017 17:51:53 +0200 MIME-Version: 1.0 In-Reply-To: <20171018155038.GG17962@localhost.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 03/10] qemu-iotests: automatically clean up bash protocol servers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: qemu-devel@nongnu.org, kwolf@redhat.com, jsnow@redhat.com, stefanha@redhat.com, qemu-block@nongnu.org On 18/10/2017 17:50, Jeff Cody wrote: > Here is what we need from common.rc for this series: > > _rm_test_img > _cleanup_nbd > _cleanup_vxhs > _cleanup_rbd > _cleanup_sheepdog > _cleanup_protocols > _cleanup_test_img > > > They all have a common theme (cleanup), so I could move them all to a > common.cleanup (naming suggestion?) file (which would need to be included by > common.rc, as well). > > Would this be a strong enough delineation to overcome your concerns? A great start. Which of these are actually needed by the tests (and hence by common.rc) and why? Paolo