From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40728) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCP2a-0001YT-Od for qemu-devel@nongnu.org; Wed, 08 Nov 2017 07:01:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCP2R-0000V0-77 for qemu-devel@nongnu.org; Wed, 08 Nov 2017 07:01:08 -0500 References: <20171107172638.29942-1-kwolf@redhat.com> <20171107173920.GK3213@redhat.com> <357d61df-9bad-dc5a-1878-2fce4b2a93cc@redhat.com> <20171108104907.GN12670@redhat.com> <20171108115127.GC30890@localhost.localdomain> From: Paolo Bonzini Message-ID: Date: Wed, 8 Nov 2017 13:00:38 +0100 MIME-Version: 1.0 In-Reply-To: <20171108115127.GC30890@localhost.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block: Deprecate bdrv_set_read_only() and users List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , "Daniel P. Berrange" Cc: mreitz@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org, armbru@redhat.com On 08/11/2017 12:51, Kevin Wolf wrote: > Am 08.11.2017 um 11:49 hat Daniel P. Berrange geschrieben: >> On Wed, Nov 08, 2017 at 11:44:01AM +0100, Paolo Bonzini wrote: >>> I am not sure this counts as deprecation, but it should go in the >>> release notes as "future incompatible changes", and that section >>> probably should go in qemu-doc.texi itself. >> >> Yeah, adding a "Incompatible changes" appendix to the qemu-doc.texi >> would be useful, listing the planned change, and when it is actually >> made. That way apps adding support for a feature have an indication >> of any incompatiblities they might need to care about. > > You mean a section containing future incompatible changes as well as > already implemented incompatible changes? > > What would we do with the existing "Deprecated features" section? Would > it become a subsection of "Incompatible changes"? Or would we just > rename it and the subsections would stay on the same level and get > "deprecated" added to their title? Or a completely different structure? > > I'm okay with adding a little documentation in this patch if I know what > it should look like, but if it turns into a major overhaul of the > documentation on incompatible changes, it's probably out of scope for > this patch. For now I would just add a section to the changelog. That ensures that we don't forget and end up doing nothing. Paolo