From: Thomas Huth <thuth@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [PATCH] tests/qemu-iotest: fix iotest 024 with qed images
Date: Thu, 13 Nov 2025 08:29:54 +0100 [thread overview]
Message-ID: <f5ea38e0-e707-4222-ad69-2edf39d5fe15@redhat.com> (raw)
In-Reply-To: <20251112170959.700840-1-berto@igalia.com>
On 12/11/2025 18.09, Alberto Garcia wrote:
> Use 'qemu-io -c map' instead of 'qemu-img map' to get an output that
> works with both image types.
>
> Cc: qemu-stable <qemu-stable@nongnu.org>
> Fixes: 909852ba6b4a ("qemu-img rebase: don't exceed IO_BUF_SIZE in one operation")
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> tests/qemu-iotests/024 | 2 +-
> tests/qemu-iotests/024.out | 3 +--
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/tests/qemu-iotests/024 b/tests/qemu-iotests/024
> index 021169b4a1..10be2bd845 100755
> --- a/tests/qemu-iotests/024
> +++ b/tests/qemu-iotests/024
> @@ -359,7 +359,7 @@ $QEMU_IO "$OVERLAY" -c "read -P 0x00 0 1M" | _filter_qemu_io
> $QEMU_IO "$OVERLAY" -c "read -P 0xff 1M 2M" | _filter_qemu_io
> $QEMU_IO "$OVERLAY" -c "read -P 0x00 3M 1M" | _filter_qemu_io
>
> -$QEMU_IMG map "$OVERLAY" | _filter_qemu_img_map
> +$QEMU_IO -c map "$OVERLAY" | _filter_qemu_io
>
> echo
>
> diff --git a/tests/qemu-iotests/024.out b/tests/qemu-iotests/024.out
> index 1b7522ba71..da8fedc08b 100644
> --- a/tests/qemu-iotests/024.out
> +++ b/tests/qemu-iotests/024.out
> @@ -266,7 +266,6 @@ read 2097152/2097152 bytes at offset 1048576
> 2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> read 1048576/1048576 bytes at offset 3145728
> 1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> -Offset Length File
> -0 0x400000 TEST_DIR/subdir/t.IMGFMT
> +4 MiB (0x400000) bytes allocated at offset 0 bytes (0x0)
>
> *** done
Thanks!
Tested-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2025-11-13 7:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 17:09 [PATCH] tests/qemu-iotest: fix iotest 024 with qed images Alberto Garcia
2025-11-12 21:35 ` Eric Blake
2025-11-13 7:29 ` Thomas Huth [this message]
2025-11-13 22:42 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5ea38e0-e707-4222-ad69-2edf39d5fe15@redhat.com \
--to=thuth@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).