From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56382C433DF for ; Thu, 11 Jun 2020 17:50:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2048C20792 for ; Thu, 11 Jun 2020 17:50:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qHtGbHwj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2048C20792 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56448 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jjRLt-0003yG-8t for qemu-devel@archiver.kernel.org; Thu, 11 Jun 2020 13:50:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48890) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jjRKQ-0002ns-HX for qemu-devel@nongnu.org; Thu, 11 Jun 2020 13:49:26 -0400 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]:41934) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jjRKN-0008JF-Uh for qemu-devel@nongnu.org; Thu, 11 Jun 2020 13:49:26 -0400 Received: by mail-pl1-x641.google.com with SMTP id y17so2591534plb.8 for ; Thu, 11 Jun 2020 10:49:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WUs2i+u0sS2JwcAlnZgkKZ6Y5GV20ctNTuW5azgaPTw=; b=qHtGbHwjyuh4wSxzrjznY9MMUFsnWddMQZB+tosOSFJ9GKGVQzptq0M0NK7R6dwfPx U0jWS2cwlF0o+yGLYXJHGEgOM1REmGzC4plNmfpQ3BoITOTUn3USadm7+4a4t5KMiEqa duhROJ621Q9cBnMps9alktOOQdNXNUJcNrmOj1WTkPeZw/FCsMRj0WfKk9+HyFCCKnYE uV2KxOropWaIQ6QltAL0ePrMFXAHiTWDi6wxiFdGPtVoeNWRJOM3RKieIRsK3u9jwrUk 5BLsUk3/wfhIdWz6cmwTqgb5sQ1esiFv8i3Brh3ghCSwTOQMGZUg1AUmBQ08p2vPkVq+ YNsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WUs2i+u0sS2JwcAlnZgkKZ6Y5GV20ctNTuW5azgaPTw=; b=lYdWAHS6yd1E/wxTADoev+KkQnPVS4tNhmkS2Xa9Qv9ZfcloQjjapZrc9u0qcIgQWQ S5evbILM4457O5tYh9RJ6LVvVZeGg5jJSafOnX8jRllXyUGodgjCoaoq9NRSUu17PeNZ GdeWdPf0l+yFvjDKxL2e5QjpPP6RCSEOcIUk1K/6IxZAPFFi7tEVppRlxvMlJzTLKjZ6 REhMPLwYR4ejYpgpK1Q4lxsodNhgg4f0k1lEl5yoGmTFwizSn2bWO6EsFFmIY9SlU0L8 u1pJRZiHuthinSx+EVCxIOn+mlqWU78/fN0aOd4C0LHpMCz/VRH1IiWpr6uLfqSMX7MG 1TCg== X-Gm-Message-State: AOAM531FNjkWoGurmQmZ3yg2kRZQFmt3xszNJKQ000xZzF4UNmLi0H25 WHvDzMiV4gsJNLPNCVLMyu0rEg== X-Google-Smtp-Source: ABdhPJx9LZXFg1xr2euBLW80ZZ2CTO2OJMu0UcnrRTfv5alwdyXUb/5rg+epO+l4AtvtFkqbXVEt0g== X-Received: by 2002:a17:90a:fa95:: with SMTP id cu21mr8831937pjb.56.1591897752659; Thu, 11 Jun 2020 10:49:12 -0700 (PDT) Received: from [192.168.1.11] (174-21-143-238.tukw.qwest.net. [174.21.143.238]) by smtp.gmail.com with ESMTPSA id n189sm3809276pfn.108.2020.06.11.10.49.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2020 10:49:11 -0700 (PDT) Subject: Re: [PATCH v2 5/5] configure: Add -Wno-psabi To: =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20200610203942.887374-1-richard.henderson@linaro.org> <20200610203942.887374-6-richard.henderson@linaro.org> <87bllp4kn1.fsf@linaro.org> <9d416d2e-593d-61c5-ab20-7b182a7bb757@linaro.org> <877dwd4j4n.fsf@linaro.org> From: Richard Henderson Message-ID: Date: Thu, 11 Jun 2020 10:49:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <877dwd4j4n.fsf@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::641; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x641.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/11/20 10:17 AM, Alex Bennée wrote: > > Richard Henderson writes: > >> On 6/11/20 9:44 AM, Alex Bennée wrote: >>> >>> Richard Henderson writes: >>> >>>> On aarch64, gcc 9.3 is generating >>>> >>>> qemu/exec.c: In function ‘address_space_translate_iommu’: >>>> qemu/exec.c:431:28: note: parameter passing for argument of type \ >>>> ‘MemTxAttrs’ {aka ‘struct MemTxAttrs’} changed in GCC 9.1 >>>> >>>> and many other reptitions. This structure, and the functions >>>> amongst which it is passed, are not part of a QEMU public API. >>>> Therefore we do not care how the compiler passes the argument, >>>> so long as the compiler is self-consistent. >>>> >>>> Cc: Alex Bennée >>>> Cc: Peter Maydell >>>> Signed-off-by: Richard Henderson >>>> --- >>>> TODO: The only portion of QEMU which does have a public api, >>>> and so must have a stable abi, is "qemu/plugin.h". We could >>>> test this by forcing -Wpsabi or -Werror=psabi in tests/plugin. >>>> I can't seem to make that work -- Alex? >>> >>> modified plugins/Makefile.objs >>> @@ -5,6 +5,7 @@ >>> obj-y += loader.o >>> obj-y += core.o >>> obj-y += api.o >>> +api.o-cflags := -Wpsabi >>> >>> # Abuse -libs suffix to only link with --dynamic-list/-exported_symbols_list >>> # when the final binary includes the plugin object. >>> >>> Seems to work for me. >> >> Wrong directory -- that's the part that goes into qemu, which also uses other >> qemu internal headers. As opposed to the tests/, which only use the one >> "qemu/plugins.h" header (plus libc). > > It's a sub-make so I just did: > > modified tests/plugin/Makefile > @@ -18,7 +18,7 @@ NAMES += hwprofile > > SONAMES := $(addsuffix .so,$(addprefix lib,$(NAMES))) > > -QEMU_CFLAGS += -fPIC > +QEMU_CFLAGS += -fPIC -Wpsabi > QEMU_CFLAGS += -I$(SRC_PATH)/include/qemu Did you look at the actual flags passed to the actual cc via V=1? Neither of these flags is arriving. I sent you mail about this yesterday... r~