From: "wangyanan (Y)" via <qemu-devel@nongnu.org>
To: Peter Maydell <peter.maydell@linaro.org>, <qemu-devel@nongnu.org>,
<qemu-trivial@nongnu.org>
Subject: Re: [PATCH] qdev-core.h: Fix wrongly named reference to TYPE_SPLIT_IRQ
Date: Wed, 12 Jan 2022 09:42:01 +0800 [thread overview]
Message-ID: <f5f2bce4-5572-ad6d-c36e-b79406e5d9ca@huawei.com> (raw)
In-Reply-To: <20220111172655.3546766-1-peter.maydell@linaro.org>
On 2022/1/12 1:26, Peter Maydell wrote:
> Fix a comment in qdev-core.h where we incorrectly referred
> to TYPE_IRQ_SPLIT when we meant TYPE_SPLIT_IRQ.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> include/hw/qdev-core.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
> index d19c9417520..92c3d652086 100644
> --- a/include/hw/qdev-core.h
> +++ b/include/hw/qdev-core.h
> @@ -493,7 +493,7 @@ qemu_irq qdev_get_gpio_in_named(DeviceState *dev, const char *name, int n);
> * qemu_irqs at once, or to connect multiple outbound GPIOs to the
> * same qemu_irq. (Warning: there is no assertion or other guard to
> * catch this error: the model will just not do the right thing.)
> - * Instead, for fan-out you can use the TYPE_IRQ_SPLIT device: connect
> + * Instead, for fan-out you can use the TYPE_SPLIT_IRQ device: connect
> * a device's outbound GPIO to the splitter's input, and connect each
> * of the splitter's outputs to a different device. For fan-in you
> * can use the TYPE_OR_IRQ device, which is a model of a logical OR
Reviewed-by: Yanan Wang <wangyanan55@huawei.com>
next prev parent reply other threads:[~2022-01-12 1:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 17:26 [PATCH] qdev-core.h: Fix wrongly named reference to TYPE_SPLIT_IRQ Peter Maydell
2022-01-11 17:52 ` Philippe Mathieu-Daudé
2022-01-12 1:42 ` wangyanan (Y) via [this message]
2022-01-12 14:43 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5f2bce4-5572-ad6d-c36e-b79406e5d9ca@huawei.com \
--to=qemu-devel@nongnu.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-trivial@nongnu.org \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).