qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] qdev-core.h: Fix wrongly named reference to TYPE_SPLIT_IRQ
@ 2022-01-11 17:26 Peter Maydell
  2022-01-11 17:52 ` Philippe Mathieu-Daudé
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Peter Maydell @ 2022-01-11 17:26 UTC (permalink / raw)
  To: qemu-devel, qemu-trivial

Fix a comment in qdev-core.h where we incorrectly referred
to TYPE_IRQ_SPLIT when we meant TYPE_SPLIT_IRQ.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 include/hw/qdev-core.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
index d19c9417520..92c3d652086 100644
--- a/include/hw/qdev-core.h
+++ b/include/hw/qdev-core.h
@@ -493,7 +493,7 @@ qemu_irq qdev_get_gpio_in_named(DeviceState *dev, const char *name, int n);
  * qemu_irqs at once, or to connect multiple outbound GPIOs to the
  * same qemu_irq. (Warning: there is no assertion or other guard to
  * catch this error: the model will just not do the right thing.)
- * Instead, for fan-out you can use the TYPE_IRQ_SPLIT device: connect
+ * Instead, for fan-out you can use the TYPE_SPLIT_IRQ device: connect
  * a device's outbound GPIO to the splitter's input, and connect each
  * of the splitter's outputs to a different device.  For fan-in you
  * can use the TYPE_OR_IRQ device, which is a model of a logical OR
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] qdev-core.h: Fix wrongly named reference to TYPE_SPLIT_IRQ
  2022-01-11 17:26 [PATCH] qdev-core.h: Fix wrongly named reference to TYPE_SPLIT_IRQ Peter Maydell
@ 2022-01-11 17:52 ` Philippe Mathieu-Daudé
  2022-01-12  1:42 ` wangyanan (Y) via
  2022-01-12 14:43 ` Laurent Vivier
  2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-01-11 17:52 UTC (permalink / raw)
  To: Peter Maydell, qemu-devel, qemu-trivial

On 1/11/22 18:26, Peter Maydell wrote:
> Fix a comment in qdev-core.h where we incorrectly referred
> to TYPE_IRQ_SPLIT when we meant TYPE_SPLIT_IRQ.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  include/hw/qdev-core.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] qdev-core.h: Fix wrongly named reference to TYPE_SPLIT_IRQ
  2022-01-11 17:26 [PATCH] qdev-core.h: Fix wrongly named reference to TYPE_SPLIT_IRQ Peter Maydell
  2022-01-11 17:52 ` Philippe Mathieu-Daudé
@ 2022-01-12  1:42 ` wangyanan (Y) via
  2022-01-12 14:43 ` Laurent Vivier
  2 siblings, 0 replies; 4+ messages in thread
From: wangyanan (Y) via @ 2022-01-12  1:42 UTC (permalink / raw)
  To: Peter Maydell, qemu-devel, qemu-trivial


On 2022/1/12 1:26, Peter Maydell wrote:
> Fix a comment in qdev-core.h where we incorrectly referred
> to TYPE_IRQ_SPLIT when we meant TYPE_SPLIT_IRQ.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   include/hw/qdev-core.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
> index d19c9417520..92c3d652086 100644
> --- a/include/hw/qdev-core.h
> +++ b/include/hw/qdev-core.h
> @@ -493,7 +493,7 @@ qemu_irq qdev_get_gpio_in_named(DeviceState *dev, const char *name, int n);
>    * qemu_irqs at once, or to connect multiple outbound GPIOs to the
>    * same qemu_irq. (Warning: there is no assertion or other guard to
>    * catch this error: the model will just not do the right thing.)
> - * Instead, for fan-out you can use the TYPE_IRQ_SPLIT device: connect
> + * Instead, for fan-out you can use the TYPE_SPLIT_IRQ device: connect
>    * a device's outbound GPIO to the splitter's input, and connect each
>    * of the splitter's outputs to a different device.  For fan-in you
>    * can use the TYPE_OR_IRQ device, which is a model of a logical OR
Reviewed-by: Yanan Wang <wangyanan55@huawei.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] qdev-core.h: Fix wrongly named reference to TYPE_SPLIT_IRQ
  2022-01-11 17:26 [PATCH] qdev-core.h: Fix wrongly named reference to TYPE_SPLIT_IRQ Peter Maydell
  2022-01-11 17:52 ` Philippe Mathieu-Daudé
  2022-01-12  1:42 ` wangyanan (Y) via
@ 2022-01-12 14:43 ` Laurent Vivier
  2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2022-01-12 14:43 UTC (permalink / raw)
  To: Peter Maydell, qemu-devel, qemu-trivial

Le 11/01/2022 à 18:26, Peter Maydell a écrit :
> Fix a comment in qdev-core.h where we incorrectly referred
> to TYPE_IRQ_SPLIT when we meant TYPE_SPLIT_IRQ.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   include/hw/qdev-core.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
> index d19c9417520..92c3d652086 100644
> --- a/include/hw/qdev-core.h
> +++ b/include/hw/qdev-core.h
> @@ -493,7 +493,7 @@ qemu_irq qdev_get_gpio_in_named(DeviceState *dev, const char *name, int n);
>    * qemu_irqs at once, or to connect multiple outbound GPIOs to the
>    * same qemu_irq. (Warning: there is no assertion or other guard to
>    * catch this error: the model will just not do the right thing.)
> - * Instead, for fan-out you can use the TYPE_IRQ_SPLIT device: connect
> + * Instead, for fan-out you can use the TYPE_SPLIT_IRQ device: connect
>    * a device's outbound GPIO to the splitter's input, and connect each
>    * of the splitter's outputs to a different device.  For fan-in you
>    * can use the TYPE_OR_IRQ device, which is a model of a logical OR

Applied to my trivial-patches branch.

Thanks,
Laurent


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-01-12 15:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-11 17:26 [PATCH] qdev-core.h: Fix wrongly named reference to TYPE_SPLIT_IRQ Peter Maydell
2022-01-11 17:52 ` Philippe Mathieu-Daudé
2022-01-12  1:42 ` wangyanan (Y) via
2022-01-12 14:43 ` Laurent Vivier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).