From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44174) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpwFu-0003ZW-O4 for qemu-devel@nongnu.org; Thu, 07 Sep 2017 08:50:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dpwFl-0005R3-Fp for qemu-devel@nongnu.org; Thu, 07 Sep 2017 08:50:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43900) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dpwFl-0005QP-8o for qemu-devel@nongnu.org; Thu, 07 Sep 2017 08:49:53 -0400 References: <20170904154316.4148-1-david@redhat.com> <20170904154316.4148-12-david@redhat.com> <2c620927-0406-2fc1-895c-09ffc2e44a4e@linux.vnet.ibm.com> <6b3e9c2b-4cb7-fdf8-5f9b-ff7ebbf52d1e@linaro.org> From: David Hildenbrand Message-ID: Date: Thu, 7 Sep 2017 14:49:49 +0200 MIME-Version: 1.0 In-Reply-To: <6b3e9c2b-4cb7-fdf8-5f9b-ff7ebbf52d1e@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 11/19] s390x: allow only 1 CPU with TCG List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , Matthew Rosato , qemu-devel@nongnu.org Cc: thuth@redhat.com, Eduardo Habkost , cohuck@redhat.com, Alexander Graf , borntraeger@de.ibm.com On 06.09.2017 23:20, Richard Henderson wrote: > On 09/06/2017 11:16 AM, Matthew Rosato wrote: >> On 09/04/2017 11:43 AM, David Hildenbrand wrote: >>> Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the >>> guest tries to bring these CPUs up but fails), because we don't support >>> multiple CPUs on s390x under TCG. >>> >>> Let's bail out if more than 1 is specified, so we don't raise people's >>> hope. Make it a define, so we can easily bump it up later. >>> >>> Signed-off-by: David Hildenbrand >>> --- >> >> Makes sense. Ran the described environment without this patch (errors) >> and again with this patch (graceful exit w/ message). >> >> Tested-by: Matthew Rosato > > Can someone review > > http://patchwork.ozlabs.org/patch/760010/ > Yes, we also discovered that patch during review of v1. > which does at least start to add the SIGP support. > > Once tcg can bring up 2 cpus, I see no reason it couldn't bring up N. I don't > see the point of the define. > Conny requested a define. So it boils down to a) no define just as in v1 b) a define like S390_TCG_SMP_SUPPORTED What do you suggest? > > r~ > -- Thanks, David