From: Richard Henderson <richard.henderson@linaro.org>
To: Helge Deller <deller@gmx.de>, Laurent Vivier <laurent@vivier.eu>,
qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
John Reiser <jreiser@bitwagon.com>,
"Markus F.X.J. Oberhumer" <markus@oberhumer.com>
Subject: Re: [PATCH v2] linux-user/armeb: Fix __kernel_cmpxchg() for armeb
Date: Fri, 28 Jul 2023 08:35:47 -0700 [thread overview]
Message-ID: <f6129139-54f6-1d96-1edc-cb1bdf7dac89@linaro.org> (raw)
In-Reply-To: <ZMNJ+Ga7A4zDXjAg@p100>
On 7/27/23 21:54, Helge Deller wrote:
> @@ -174,6 +175,10 @@ static void arm_kernel_cmpxchg64_helper(CPUARMState *env)
> return;
> }
>
> + /* endianess-swap if emulating armeb */
> + oldval = tswap32(oldval);
> + newval = tswap32(newval);
Must be tswap64.
r~
next prev parent reply other threads:[~2023-07-28 15:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 4:54 [PATCH v2] linux-user/armeb: Fix __kernel_cmpxchg() for armeb Helge Deller
2023-07-28 5:17 ` Markus F.X.J. Oberhumer
2023-07-28 5:45 ` Markus F.X.J. Oberhumer
2023-07-28 15:35 ` Richard Henderson [this message]
2023-07-28 19:16 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6129139-54f6-1d96-1edc-cb1bdf7dac89@linaro.org \
--to=richard.henderson@linaro.org \
--cc=deller@gmx.de \
--cc=jreiser@bitwagon.com \
--cc=laurent@vivier.eu \
--cc=markus@oberhumer.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).