From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7g9h-00033r-0C for qemu-devel@nongnu.org; Wed, 03 Oct 2018 08:21:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g7g9g-0004eF-BC for qemu-devel@nongnu.org; Wed, 03 Oct 2018 08:21:28 -0400 References: <20181002230218.13949-1-jsnow@redhat.com> <20181002230218.13949-4-jsnow@redhat.com> From: Eric Blake Message-ID: Date: Wed, 3 Oct 2018 07:21:10 -0500 MIME-Version: 1.0 In-Reply-To: <20181002230218.13949-4-jsnow@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 3/6] block/dirty-bitmaps: allow clear on disabled bitmaps List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: Markus Armbruster , "Dr. David Alan Gilbert" , Kevin Wolf , Juan Quintela , Paolo Bonzini , vsementsov@virtuozzo.com, Fam Zheng , Max Reitz , Stefan Hajnoczi On 10/2/18 6:02 PM, John Snow wrote: > Similarly to merge, it's OK to allow clear operations on disabled > bitmaps, as this condition only means that they are not recording > new writes. We are free to clear it if the user requests it. > > Signed-off-by: John Snow > --- > block/dirty-bitmap.c | 1 - > blockdev.c | 8 -------- > 2 files changed, 9 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org