From: Thomas Huth <thuth@redhat.com>
To: Stefan Berger <stefanb@linux.ibm.com>, qemu-devel@nongnu.org
Cc: marcandre.lureau@redhat.com, clg@kaod.org, ninad@linux.ibm.com,
joel@jms.id.au, andrew@aj.id.au
Subject: Re: [PATCH v4 2/3] qtest: Move tpm_util_tis_transmit() into tpm-tis-utils.c and rename it
Date: Fri, 31 Mar 2023 12:24:28 +0200 [thread overview]
Message-ID: <f62bf8c8-e196-4a83-265b-5196279de9ac@redhat.com> (raw)
In-Reply-To: <20230328171958.3677734-3-stefanb@linux.ibm.com>
On 28/03/2023 19.19, Stefan Berger wrote:
> To be able to remove tpm_tis_base_addr from test cases that do not really
> need it move the tpm_util_tis_transmit() function into tpm-tis-utils.c and
> rename it to tpm_tis_transmit().
>
> Fix a locality parameter in a test case on the way.
>
> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
> Reviewed-by: Ninad Palsule <ninad@linux.ibm.com>
> ---
> tests/qtest/tpm-crb-swtpm-test.c | 3 --
> tests/qtest/tpm-crb-test.c | 3 --
> tests/qtest/tpm-tis-device-swtpm-test.c | 5 +--
> tests/qtest/tpm-tis-swtpm-test.c | 5 +--
> tests/qtest/tpm-tis-util.c | 47 ++++++++++++++++++++++++-
> tests/qtest/tpm-tis-util.h | 4 +++
> tests/qtest/tpm-util.c | 45 -----------------------
> tests/qtest/tpm-util.h | 3 --
> 8 files changed, 56 insertions(+), 59 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2023-03-31 10:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 17:19 [PATCH v4 0/3] qtests: tpm: Add test cases for TPM TIS I2C device emulation Stefan Berger
2023-03-28 17:19 ` [PATCH v4 1/3] qtest: Add functions for accessing devices on Aspeed I2C controller Stefan Berger
2023-03-31 10:20 ` Thomas Huth
2023-03-28 17:19 ` [PATCH v4 2/3] qtest: Move tpm_util_tis_transmit() into tpm-tis-utils.c and rename it Stefan Berger
2023-03-31 10:24 ` Thomas Huth [this message]
2023-03-28 17:19 ` [PATCH v4 3/3] qtest: Add a test case for TPM TIS I2C connected to Aspeed I2C controller Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f62bf8c8-e196-4a83-265b-5196279de9ac@redhat.com \
--to=thuth@redhat.com \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=marcandre.lureau@redhat.com \
--cc=ninad@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).