From: Thomas Huth <thuth@redhat.com>
To: Eric Farman <farman@linux.vnet.ibm.com>, cohuck@redhat.com
Cc: borntraeger@de.ibm.com, agraf@suse.de, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target
Date: Tue, 15 Aug 2017 07:02:10 +0200 [thread overview]
Message-ID: <f637c206-266c-d76f-852e-4800422838bb@redhat.com> (raw)
In-Reply-To: <20170814204450.24118-1-farman@linux.vnet.ibm.com>
On 14.08.2017 22:44, Eric Farman wrote:
> How often does one really do a "make clean" ? Rather infrequently,
> as I only stumbled on this today.
>
> Perhaps I have missed the RM variable somewhere, as I see similar syntax
> in some of the tests/tcg/ Makefiles, but I don't see it being set here.
> My configure statement isn't terribly interesting, just enabling debug
> for an s390x target, and as such there's no RM variable in its output.
> I'll trust that Thomas will chime in with where it should have been.
> In the meantime, this does the trick for me.
RM is one of the variables that should be pre-initialized by Make, and
AFAIK should be used to increase portability (well, it's likely not
important for QEMU since we require a posix-shell like built environment
anyway).
According to the info page of Make, chapter "10.3 Variables Used by
Implicit Rules":
`RM'
Command to remove a file; default `rm -f'.
I've also checked it again and "make clean" works fine here (using GNU
Make 3.82). Which version of Make (and Linux distro) are you using?
Anyway, maybe I also simply missed something, so I'm certainly also fine
with the patch to revert it to "rm -f".
Thomas
next prev parent reply other threads:[~2017-08-15 5:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 20:44 [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target Eric Farman
2017-08-14 20:44 ` [Qemu-devel] [PATCH 1/1] pc-bios/s390-ccw: Use rm command during make clean Eric Farman
2017-08-15 7:23 ` Cornelia Huck
2017-08-15 5:02 ` Thomas Huth [this message]
2017-08-15 7:03 ` [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target Cornelia Huck
2017-08-15 8:01 ` Thomas Huth
2017-08-15 8:26 ` Thomas Huth
2017-08-15 8:32 ` Cornelia Huck
2017-08-15 8:39 ` Thomas Huth
2017-08-15 10:27 ` Eric Farman
2017-08-15 10:00 ` Peter Maydell
2017-08-15 11:07 ` Cornelia Huck
2017-08-15 11:10 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f637c206-266c-d76f-852e-4800422838bb@redhat.com \
--to=thuth@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=farman@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).