From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmoiF-0000hO-OG for qemu-devel@nongnu.org; Wed, 21 Sep 2016 17:05:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmoiB-0002Iy-HS for qemu-devel@nongnu.org; Wed, 21 Sep 2016 17:05:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36984) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmoiB-0002In-BL for qemu-devel@nongnu.org; Wed, 21 Sep 2016 17:05:47 -0400 References: <20160921201018.20957-1-marcandre.lureau@redhat.com> <20160921201018.20957-2-marcandre.lureau@redhat.com> From: Eric Blake Message-ID: Date: Wed, 21 Sep 2016 16:05:44 -0500 MIME-Version: 1.0 In-Reply-To: <20160921201018.20957-2-marcandre.lureau@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="V8ovhx9FfaBbIHT3DqGVeNmNCSBXsdDUe" Subject: Re: [Qemu-devel] [PATCH v2 1/4] qapi: add assert about root value List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , qemu-devel@nongnu.org Cc: berto@igalia.com, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --V8ovhx9FfaBbIHT3DqGVeNmNCSBXsdDUe From: Eric Blake To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , qemu-devel@nongnu.org Cc: berto@igalia.com, armbru@redhat.com Message-ID: Subject: Re: [PATCH v2 1/4] qapi: add assert about root value References: <20160921201018.20957-1-marcandre.lureau@redhat.com> <20160921201018.20957-2-marcandre.lureau@redhat.com> In-Reply-To: <20160921201018.20957-2-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/21/2016 03:10 PM, Marc-Andr=C3=A9 Lureau wrote: > qiv->root should not be null, make that clearer with some assert. >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > qapi/qmp-input-visitor.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --V8ovhx9FfaBbIHT3DqGVeNmNCSBXsdDUe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX4vYoAAoJEKeha0olJ0NqjJMH/R/OXkma96XCJyInLfsNkzaz s3Ftlnu+naTqcNMqUPJJrCPnlsn186PD/lKlM5QdByAD+l4oc+cHACb99Kbhd2FU DGadwm83xT81zolHAtT/GZzT8oWQE1ERthfTLQ2bNj8Ii33yCJmXIiIj+qY6rc1V 0mM8YrA4GJvG7ZQo44HZgHKKrGT3bygVGThacTmYzyNuTmp0A64AnlzzqyCYc4uj WoSQyIYPcFC4CM5X+iB2WN5Aw2F19Pp5GOtSyBzohXJoLD+CA8O8MARfAlWOK/B9 vtzm3pMcJTTcL5wEoTmgrF2fAaPJ+9lF8+SEWh3E1C5akS+6YC2LhrIvpndpVTQ= =eFIN -----END PGP SIGNATURE----- --V8ovhx9FfaBbIHT3DqGVeNmNCSBXsdDUe--