From: Stefan Berger <stefanb@linux.ibm.com>
To: Ninad Palsule <ninad@linux.ibm.com>, qemu-devel@nongnu.org
Cc: joel@jms.id.au, andrew@aj.id.au, clg@kaod.org
Subject: Re: [PATCH v9 3/3] tpm: Add support for TPM device over I2C bus
Date: Mon, 27 Mar 2023 14:26:16 -0400 [thread overview]
Message-ID: <f648077b-8ca5-d93a-64ee-c9d4a63cbe17@linux.ibm.com> (raw)
In-Reply-To: <20230327181241.4046253-4-ninad@linux.ibm.com>
On 3/27/23 14:12, Ninad Palsule wrote:
> diff --git a/hw/tpm/tpm_tis_i2c.c b/hw/tpm/tpm_tis_i2c.c
> new file mode 100644
> index 0000000000..551b89dac8
> --- /dev/null
> +++ b/hw/tpm/tpm_tis_i2c.c
> @@ -0,0 +1,527 @@
> +/*
> + * Aspeed i2c bus interface for reading from and writing to i2c device registers
This was my suggestion for the format but this is not the correct line.
With this line reverted to tpm_tis_i2c.c - QEMU's TPM TIS I2C Device
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
Tested-by: Stefan Berger <stefanb@linux.ibm.com>
next prev parent reply other threads:[~2023-03-27 18:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 18:12 [PATCH v9 0/3] Add support for TPM devices over I2C bus Ninad Palsule
2023-03-27 18:12 ` [PATCH v9 1/3] docs: " Ninad Palsule
2023-03-27 18:15 ` Stefan Berger
2023-03-27 18:12 ` [PATCH v9 2/3] tpm: Extend common APIs to support TPM TIS I2C Ninad Palsule
2023-03-27 18:18 ` Stefan Berger
2023-03-27 18:12 ` [PATCH v9 3/3] tpm: Add support for TPM device over I2C bus Ninad Palsule
2023-03-27 18:26 ` Stefan Berger [this message]
2023-03-27 18:34 ` Ninad Palsule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f648077b-8ca5-d93a-64ee-c9d4a63cbe17@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=ninad@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).