From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23DF9C433F5 for ; Thu, 28 Oct 2021 11:56:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE16C60F56 for ; Thu, 28 Oct 2021 11:56:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AE16C60F56 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:54706 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mg41H-0007vS-TA for qemu-devel@archiver.kernel.org; Thu, 28 Oct 2021 07:56:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45684) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mg3vq-0002EP-UN for qemu-devel@nongnu.org; Thu, 28 Oct 2021 07:50:55 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:2837) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mg3vn-0003S1-NL for qemu-devel@nongnu.org; Thu, 28 Oct 2021 07:50:54 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Hg3fY2hD1zbhGl; Thu, 28 Oct 2021 19:45:57 +0800 (CST) Received: from dggpemm500023.china.huawei.com (7.185.36.83) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Thu, 28 Oct 2021 19:50:37 +0800 Received: from [10.174.187.128] (10.174.187.128) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.15; Thu, 28 Oct 2021 19:50:36 +0800 Subject: Re: [PATCH v3 0/2] hw/core/machine: Add an unit test for smp_parse To: References: <20211026034659.22040-1-wangyanan55@huawei.com> From: "wangyanan (Y)" Message-ID: Date: Thu, 28 Oct 2021 19:50:36 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20211026034659.22040-1-wangyanan55@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.174.187.128] X-ClientProxiedBy: dggeme710-chm.china.huawei.com (10.1.199.106) To dggpemm500023.china.huawei.com (7.185.36.83) X-CFilter-Loop: Reflected Received-SPF: pass client-ip=45.249.212.188; envelope-from=wangyanan55@huawei.com; helo=szxga02-in.huawei.com X-Spam_score_int: -69 X-Spam_score: -7.0 X-Spam_bar: ------- X-Spam_report: (-7.0 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-2.847, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Jones , =?UTF-8?Q?Daniel_P_=2e_Berrang=c3=a9?= , Eduardo Habkost , Markus Armbruster , wanghaibin.wang@huawei.com, Paolo Bonzini , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi, Does this short series have a chance to get on the train for 6.2 before the closely coming soft-feature freeze? It would be very nice to have a test finally, since all the previous work on -smp code has been completed and merged, IMO. 😉 Regards, Yanan On 2021/10/26 11:46, Yanan Wang wrote: > Hi, > > This is v3 which introduces an unit test for generic smp_parse. > > We have had enough discussions about what kind of SMP configurations > by the user should be considered valid and what should be invalid. > Since we have finished optimizing the SMP parsing code, then this > test normatively listed all the possible valid/invalid configurations > that the user can provide. This can be a testing tool when we > introduce new topology members and need to touch the parsing code. > > For your reference, some related discussion is here: > https://lore.kernel.org/qemu-devel/YOxf+sxzUSJdbY+j@redhat.com/ > > Changelog: > v2->v3: > - add Andrew's R-b for PATCH #1 > - drop an unused macro definition in PATCH #2 > - v2: https://lore.kernel.org/qemu-devel/20211013074119.23028-1-wangyanan55@huawei.com/ > > v1->v2: > - split smp_parse out into a separate .c file instead of a header (patch #1) > - dropped an unnecessary function and add Andrew's R-b (patch #2) > - v1: https://lore.kernel.org/qemu-devel/20211010103954.20644-1-wangyanan55@huawei.com/ > > Yanan Wang (2): > hw/core/machine: Split out the smp parsing code > tests/unit: Add an unit test for smp parsing > > MAINTAINERS | 2 + > hw/core/machine-smp.c | 181 +++++++++++ > hw/core/machine.c | 159 ---------- > hw/core/meson.build | 2 + > include/hw/boards.h | 1 + > tests/unit/meson.build | 1 + > tests/unit/test-smp-parse.c | 594 ++++++++++++++++++++++++++++++++++++ > 7 files changed, 781 insertions(+), 159 deletions(-) > create mode 100644 hw/core/machine-smp.c > create mode 100644 tests/unit/test-smp-parse.c > > -- > 2.19.1 > > .